Modify

Opened 9 years ago

Closed 9 years ago

Last modified 4 years ago

#2312 closed defect (fixed)

[patch] fixes 0.11 version (makes ticket selection checkboxes appear)

Reported by: Morris Owned by: ashwin_phatak
Priority: high Component: BatchModifyPlugin
Severity: normal Keywords:
Cc: Morris Trac Release: 0.11

Description

Pretty much what the summary says. Specifically, the input checkboxes (to select the tickets to apply the batch mods on) weren't appearing.

Digging a bit, it turns out the jQuery code to add the checkboxes wasn't quite right (it was using raw XPath instead of jQuery) -- so I fixed that. Furthermore, the "select group" checkbox didn't work; I didn't spend much time trying to get this working as it wasn't nearly as high a priority, so I just removed the group checkbox. I may come back in the future and attempt to get the group checkbox working, but only if enough of my users scream :)

Attachments (2)

checkboxesfix.r2895.patch (7.6 KB) - added by Morris 9 years ago.
batchmod-jquery1.2.patch (2.1 KB) - added by Dave Gynn 9 years ago.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by Morris

Attachment: checkboxesfix.r2895.patch added

comment:1 Changed 9 years ago by Morris

For whatever reason, the attached .patch file doesn't preview properly in Trac, but it's fine if you download it (use the Original Format link at the bottom of the preview page).

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

Changed 9 years ago by Dave Gynn

Attachment: batchmod-jquery1.2.patch added

comment:2 Changed 9 years ago by Dave Gynn

Added a new patch that works with jQuery in no-conflict mode and uses CSS selectors instead of XPath like gt4329b's. This patch also fixes the group toggle boxes.

comment:3 Changed 9 years ago by anonymous

dgynns patch fixes the problem for me. this should be incorporated into the next release imo - else this plugin doesn't work at all in firefox.

comment:4 Changed 9 years ago by Ian Jones

works for me in firefox (3.0b5) - I would also vote for incorporation.

comment:5 Changed 9 years ago by anonymous

Added glee: the jQuery patch (batchmod-jquery1.2.patch) also caused the batch modify controls to start working again in Opera 9.27. Previously they were broken (checking the checkbox next to a field would do nothing, the field would remain disabled) for Opera, but worked in Firefox 2.0.0.12.

comment:6 Changed 9 years ago by Bas van der Vlies

Just installed the plugin and had to apply this patchto make thing work. When will this patch be applied?

comment:7 Changed 9 years ago by Dave Gynn

Resolution: fixed
Status: newclosed

Fixed. Patch applied in changeset:3916

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ashwin_phatak.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.