Modify

Opened 10 years ago

Closed 10 years ago

#2336 closed defect (fixed)

Nondeterministic depgraph generation

Reported by: Keith Davies Owned by: Keith Davies
Priority: normal Component: MasterTicketsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

If you generate the same depgraph image repeatedly, you can get different images. All I have seen are *correct*, but the arrangement varies.

If you order the nodes when you select them, that should result in deterministic depgraph generation

Attachments (1)

masterticketsplugin-kjdavies20071228.diff (8.1 KB) - added by Keith Davies 10 years ago.
Patch file fixing #2332, #2333, #2336

Download all attachments as: .zip

Change History (4)

comment:1 Changed 10 years ago by Keith Davies

Owner: changed from Noah Kantrowitz to Keith Davies

comment:2 Changed 10 years ago by Keith Davies

I have a fix for this in my local code (replace overloads on Node.gt and node.lt with Node.blocks() and Node.blockedby(), then call those functions instead)

Overloading gt and lt may be clever and look nice, but it makes for code that's nonobvious to readers and messes with sorting semantics. Once I removed the gt and lt overloads I as able to sort the nodes and edges, which gave me a consistent .dot file, which dot was able to render consistently.

Changed 10 years ago by Keith Davies

Patch file fixing #2332, #2333, #2336

comment:3 Changed 10 years ago by Noah Kantrowitz

Resolution: fixed
Status: newclosed

Fixed as of [2960].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Keith Davies.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.