Not renaming sub pages

[anonymous]

If you have a main page with a sub page, e.g. MainPage and MainPage/SubPage

When you rename MainPage to NewMainPage the subpage is not renamed as one would expect to NewMainPage/SubPage

[bialix]

automatically renaming all subpages maybe good idea but may be not: e.g. in the case when you have many subpages and sub-subpages. This may create unnecessary recurse. May be it should be done with some flag (checkbox maybe) to enable recurse renaming.

But currently wikirenameplugin update all links that match even partially to new name and it eventually break all navigation. Can you fix at least this part? I.e. don't update link to MainPage/SubPage with NewMainPage/SubPage link. Currently I encounter this bug every time I try to reorganize my very big hierarchical tree of wiki pages.

[bialix]

Simple patch to prevent renaming link to subpages:

=== modified file 'wikirename/util.py'
--- wikirename/util.py 12.11.2006 15:10:43
+++ wikirename/util.py 29.05.2008 14:40:25
@@ -82,7 +82,7 @@
     # Rewrite all links to the old page, such as to point to the new page
     for row in list(cursor):
         debug("Found a page with a backlink in it: %s (v%s)", row[1], row[0])
-        newtext = sre.sub('\[wiki:%s'%oldname,'[wiki:%s'%newname,row[2])
+        newtext = sre.sub('\[wiki:%s(?!/)'%oldname,'[wiki:%s'%newname,row[2])
         cursor.execute('UPDATE wiki SET text=%s WHERE name=%s AND version=%s', (newtext,row[1],row[0]))
 
     if handle_commit:
 

If you will decide to include this patch, please update version for Trac 0.10 as well.

[honzam+trac@…]

Wouldn't be better patch like this?

=== modified file 'wikirename/util.py'
--- wikirename/util.py 12.11.2006 15:10:43
+++ wikirename/util.py 29.05.2008 14:40:25
@@ -82,7 +82,7 @@
     # Rewrite all links to the old page, such as to point to the new page
     for row in list(cursor):
         debug("Found a page with a backlink in it: %s (v%s)", row[1], row[0])
-        newtext = re.sub('\[wiki:%s'%oldname,'[wiki:%s'%newname,row[2])
+        newtext = re.sub('\[wiki:%s(?=[ ]])'%oldname,'[wiki:%s'%newname,row[2])
         cursor.execute('UPDATE wiki SET text=%s WHERE name=%s AND version=%s' (newtext,row[1],row[0]))
 
     if handle_commit:

[Ryan J Ollos]

The plugin is deprecated since there is now support in the Trac core.

[Ryan J Ollos]

If you'd like to apply patches I can provide you commit access.