[patch] Discussion shows ctxtnav x 2 with Trac 0.11b1

[osimons]

Trac 0.11b1 now includes <div id="ctxtnav">... by default. As the plugin also adds it for its own needs, it lists twice - one is empty, the other with content. It may not show well on a default Trac (other than some extra white space), but with custom styling of navigation it becomes very obvious.

Here is a patch for adding the items through code instead:

(a) api.py vs. (b) (clipboard)

@@ -4 +4 @@
 
 from trac.core import *
 from trac.perm import PermissionError
-from trac.web.chrome import add_stylesheet, add_script
+from trac.web.chrome import add_stylesheet, add_script, add_ctxtnav
 from trac.wiki.formatter import format_to_html, format_to_oneliner
 from trac.util.datefmt import to_timestamp, to_datetime, utc, \
   format_datetime, pretty_timedelta
@@ -85 +85 @@
         self.data['mode'] = modes[-1]
         self.data['time'] = format_datetime(datetime.now(utc))
         self.data['realm'] = context.resource.realm
+        
+        # Add Context Navigation.
+        if forum:
+            add_ctxtnav(context.req, 'Forum Index',
+                    href=context.req.href.discussion())
+        if topic:
+            add_ctxtnav(context.req, forum['subject'],
+                    href=context.req.href.discussion(forum['id']))
+        if message:
+            add_ctxtnav(context.req, topic['subject'],
+                    href=context.req.href.discussion(forum['id'], topic['id']))
 
         # Add CSS styles and scripts.
         add_stylesheet(context.req, 'common/css/wiki.css')

When that is implemented, it is just a matter of removing all the

<xi:include href="wiki-discussion-header.html"/>

lines in all the templates, and removing the discussion-header.html from the project as it is no longer needed as far as i can tell.

[Radek Bartoň]

Thanks, finally Trac has common mechanism for context navigation. I have applied patch to source.