Modify

Opened 9 years ago

Closed 5 years ago

Last modified 5 years ago

#2474 closed defect (worksforme)

Include with non-standard port does not work

Reported by: Thomas Gruenhagen Owned by: Ryan J Ollos
Priority: normal Component: IncludeMacro
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

Include of any http-url via an port other than 80 seems not to work at all. Is there any way to go arround?

Regards Thomas

Attachments (0)

Change History (5)

comment:1 Changed 7 years ago by jholg

See ticket:4743 for patch that adds support for usage of non-standard http ports for included resources, among other things.

comment:2 Changed 5 years ago by Ryan J Ollos

Owner: changed from Noah Kantrowitz to Ryan J Ollos
Status: newassigned

This seems to be working fine with the latest trunk, r11627.

comment:3 Changed 5 years ago by Ryan J Ollos

Resolution: worksforme
Status: assignedclosed
Summary: Include with non standard port does not workInclude with non-standard port does not work

Also, ticket #4743 doesn't seem to have any changes for specifying a port.

comment:4 Changed 5 years ago by jholg

Not true. #4743 adds working support to actually have working intertrac support and include http resources, plus it correctly uses urlopen to access such resources which deals with any non-standard port by itself.

I must admit that I haven't tried it with a setup where an included intertrac site serves from a different port, though - can't really remember if this should work or not right now.

I use this on a day-to-day basis without any glitches (I wrote the patch so my opinion is probably biased ;-)). Note that the original IncludeMacro source can only really include (X)HTML snippets if the include source is not wiki:, although if broken (X)HTML gets included then the include might work due to the parser suddenly presenting parts of the included page to the macro that it normally wouldn't even allow.

I'd love to see #4743 changes go into the official macro - let me know if I can help.

comment:5 in reply to:  4 Changed 5 years ago by Ryan J Ollos

Replying to jholg:

plus it correctly uses urlopen to access such resources which deals with any non-standard port by itself.

Thanks for the explanation. I will looking into adding the patch now. Testers welcome :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.