Port of SvnAuthzAdminPlugin to 0.11

[Daniel Molkentin]

During a project for university we have ported SvnAuthzAdminPlugin to trac 0.11. Attached is the diff to the latest Version for 0.10:

Major changes:

• Adjustments to 0.11 API
• Ported Templates to Genshi
• Removed dependency on AccountManager plugin (used 0.11 admin infrastructure instead)

This patch probably needs some cleanups, but works for us (tm).

[gkruse@…]

I tried this patch and it worked beautifully with one exception. The code in the template that decides if the r/w checkboxes are checked or not seems to be broken. This results in both the r and w checkboxes always being checked regardless of the actual permissions. Please see the revised patch for my quick fix, however, I don't know enough genshi to know if this is the best way to fix it or not.

[gkruse@…]

Fixed r/w checkboxes

[gkruse@…]

Fixed r/w checkboxes (forgot the critical section)

[gkruse@…]

Please see lines 183-194 of admin_authz.html in revisedPatch.2.diff

[olaf.meeuwissen@…]

isolated R/W checkbox fix in separate patch

[olaf.meeuwissen@…]

I had a look at the three patches and got a bit confused at first. After looking over the patches, I finally figured out what those revised patches were trying to achieve. I've isolated the fixes in a separate patch. Now you can patch the 0.10 sources as follows:

• first apply svnauthzadminplugin_for_trac0.11.diff​
• next, apply fix-checkboxes.diff​

That should fix the checkbox problem without patch complaining all over the place ;-).

[allen]

What would I use to merge that diff file? TortoiseSVN doesn't want to apply it.

[olaf.meeuwissen@…]

Replying to envertigo:

What would I use to merge that diff file? TortoiseSVN doesn't want to apply it.

I have no experience with TortoiseSVN, but I noticed that I may have goofed up the path in the diffs. In order to apply cleanly with patch, you would do:

cd /path/to/svnauthzadminplugin
patch -p0 < svnauthzadminplugin_for_trac0.11.diff
patch -p1 < fix-checkboxes.diff

Note the difference in the number of leading path components that are stripped.

Maybe TortoiseSVN has an option that lets's you specify this? I dunno.

[anonymous]

Is there an official release for Trac 0.11?

Or, we have to apply patches as others mentioned above?

[knox]

I get the following error and dont know how whats wrong.

ParseError: ParseError: [/var/www/trac/.tmp/SvnAuthzAdminPlugin-0.1-py2.5.egg-tmp/svnauthz/templates/admin_authz.cs:14] Undefined macro called: hdf_select(editgroup.candidates, "subject", "", 0)

[anonymous]

Replying to knox:

I get the following error and dont know how whats wrong.

Shame on me! I just had to rebuild the egg from patched sources. Sorry for disturbing.

[anonymous]

the path member "*" is missing. there was one patch available for that.

[anonymous]

Replying to anonymous:

the path member "*" is missing. there was one patch available for that.

See this ticket: #4702. Implementations are more to come...

[rupert thurner]

(In [5405]) SvnAuSvnAuthzAdminPlugin, fix #2612, by applying revisedPatch.2.diff