Opened 13 years ago

Closed 13 years ago

# patch for tickets 180 and 155

Reported by: Owned by: truijllo@… Matt Good normal AccountManagerPlugin normal Gunnar Wagenknecht 0.8

Hi ! I attach here my files modified with patches for tickets #180 and #155.

#180 - only file htfile.py, new methods for various check and patch for _update_file method. Check inside for group names banned ( check group names in db and exclude them ) in trac.ini ( for environment ) must add

password_format = htpasswd
default-group = authenticated


#155 - web_ui, new check and error message for banned group names in example if you define authenticated, dev, other groups ... banned usernames will be authenticated, dev, other, WIKI_VIEW, etc etc etc ( default actions too will be protected ). api.py, new method interface

user added with these files will be created with a default permission specified in

trac.ini ==> [account-manager] ==> default-group


api.py

htfile.py

web_ui.py

### comment:1 Changed 13 years ago by Alec Thomas

Description: modified (diff)

### comment:2 Changed 13 years ago by Matt Good

Please attach diffs, not whole files. You can create a diff from a modified SVN checkout:

svn diff > mypatch.diff


This makes it much easier for developers to see what changes you've made and it's easy to apply the changes with one command:

patch -p0 < mypatch.diff


Done

### comment:4 in reply to:  description Changed 13 years ago by Gunnar Wagenknecht <gunnar@…>

Cc: gunnar@… added; anonymous removed → 0.8

password_format = htpasswd
default-group = authenticated


It's rather religious but the naming convention should be followed, i.e. default_group instead of default-group. This prevents people from mixing it up later.

But it interesting to have this feature. I was just about to open en enhancement request for this. :)

### comment:5 Changed 13 years ago by Gunnar Wagenknecht

Cc: Gunnar Wagenknecht added; gunnar@… removed

### comment:6 Changed 13 years ago by Matt Good

Resolution: → wontfix new → closed

Please, when attaching patches use the output of the "svn diff" command as I asked for above. That way you can attach a single patch file containing all the changes, rather than one diff per-file.

I've just fixed #155, and the changes for #180 already listed on that ticket are pretty simple. The "default-group" setting is not necessary since all registered users are already members of the "authenticated" group. In the future it's also easier if you provide separate patches for each issue rather than combining them, unless the changes are dependent on each other.

### comment:7 Changed 7 years ago by Ryan J Ollos

Keywords: 180 155 removed

### Modify Ticket

Change Properties