Modify

Opened 9 years ago

Last modified 8 years ago

#2794 new enhancement

wiki.putPage() provides no version check.

Reported by: anonymous Owned by: Odd Simon Simonsen
Priority: normal Component: XmlRpcPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

There's mention of the potential for lost updates on the Wiki RPC Interface page but the plugin doesn't deal with the problem.

What would be great was if wiki.WikiRPC.putPage() did a check on the page using the 'version' attribute and failed the update if it existed and didn't match page.version.

Attachments (0)

Change History (2)

comment:1 Changed 8 years ago by Odd Simon Simonsen

Owner: changed from Alec Thomas to Odd Simon Simonsen

Similar for ticket updates to prevent stale information overwriting newer property settings.

comment:2 Changed 8 years ago by Odd Simon Simonsen

Leaving this ticket to deal with wiki-side only. #5402 requests the same for tickets.

Should solve it by checking for 'version' in attributes when updating existing pages, and then failing if change is not based on most recent version.

In time, all updates should require version. This is also a frequent request mentioned in the WIKI-RPC spec.

I'll update by allowing it to pass for now (but log a warning), and update docs to recommend against such use - before deprecating use without version in some upcoming version (like 1.1).

Modify Ticket

Action
as new The owner will remain Odd Simon Simonsen.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.