Modify

Opened 16 years ago

Closed 16 years ago

#3137 closed enhancement (fixed)

Fix tests and include functional tests

Reported by: Pedro Algarvio, aka, s0undt3ch Owned by: John Hampton
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: tests
Cc: Matt Good, Noah Kantrowitz Trac Release: 0.11

Description

Here's a patch to fix tests.

  • acct_mgr/tests/db.py

     
    2121class _BaseTestCase(unittest.TestCase):
    2222    def setUp(self):
    2323        #self.basedir = os.path.realpath(tempfile.mkdtemp())
    24         self.env = EnvironmentStub()
     24        self.env = EnvironmentStub(enable=['trac.*', 'acct_mgr.*'])
    2525        self.env.config.set('account-manager', 'password_store',
    2626                            'SessionStore')
    2727        self.store = SessionStore(self.env)

Attachments (1)

fix_and_include_functional_tests.patch (31.3 KB) - added by Pedro Algarvio, aka, s0undt3ch 16 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 16 years ago by Pedro Algarvio, aka, s0undt3ch

Owner: changed from Matt Good to John Hampton

comment:2 Changed 16 years ago by Pedro Algarvio, aka, s0undt3ch

Cc: Matt Good Noah Kantrowitz added; anonymous removed
Severity: blockernormal
Summary: Fix testsFix tests and include functional tests
Type: defectenhancement

I'm including you guys in CC in order to check the tests I'm about to attach, and to let me know if you have more to include, and, of course, to see if one of you guys check's in the patch.

P.S.: It's a mercurial patch, use patch -p1 < ....

Changed 16 years ago by Pedro Algarvio, aka, s0undt3ch

comment:3 Changed 16 years ago by Pedro Algarvio, aka, s0undt3ch

If you find it good to check in I can provide a svn patch, I'd just like to keep my local acct_mgr as pristine as possible.

comment:4 Changed 16 years ago by John Hampton

Resolution: fixed
Status: newclosed

(In [3832])

  • Apply patch from s0undt3ch removing email verification for anonymous users. Refs #442
  • Apply patch from s0undt3ch implementing functional tests and fixing existing tests. Closes #3137.

Thanks for the patches s0undt3ch

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain John Hampton.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.