Modify

Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#3206 closed defect (fixed)

[PATCH] Edit Wiki Page content and tag

Reported by: Catalin BALAN Owned by: Alec Thomas
Priority: normal Component: TagsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

  • edit tags and content at the same time
  • after saving, only the tag was altered but the content remained unchanged.

The attached patch fixes that.

Thank you

Attachments (1)

tags.th.patch (703 bytes) - added by Catalin BALAN 9 years ago.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by Catalin BALAN

Attachment: tags.th.patch added

comment:1 Changed 9 years ago by Alec Thomas

Resolution: fixed
Status: newclosed

(In [3877]) Fix Wiki tag saving semantics. Fixes #3206.

comment:2 Changed 9 years ago by anonymous

Also see #3145

comment:3 Changed 9 years ago by anonymous

Resolution: fixed
Status: closedreopened

(in reply to http://trac-hacks.org/ticket/3145#comment:4)

I should have re-opened #3206 instead, even though they seem related.

At least it is not working for me. As you can see, the embedded patch *removes* some code added by [3877]. Either way, please add the setup.cfg file for the sake of those who run the trunk version.

Please investigate the patch in http://trac-hacks.org/ticket/3145#comment:3

comment:4 Changed 9 years ago by Alec Thomas

What behaviour are you seeing? The same as this bug? Or is it slightly different?

comment:5 Changed 9 years ago by James Yonan

I am seeing this issue as well with TagsPlugin 0.6 and Trac 0.11. When I attempt to create a new page (with new content) and tag it at the same time, only the tag is persisted in the DB, while the page remains in an uncreated state with the content I entered discarded.

comment:6 Changed 9 years ago by izzy

Same is happening if you update content and tags of a wiki page at the same time: Tags are updated, changes to the contents are lost. Using the latest trunk versions of both, trac and the TagsPlugin.

comment:7 Changed 8 years ago by roh

i am seeing this too. on creation one cannot add a tag without loosing the content

comment:8 Changed 7 years ago by anonymous@…

ack: same problem. is there no fix out there?

comment:9 Changed 7 years ago by Michael Renzmann

I can confirm that this bug occured with the combination of Trac 0.11.6 and TracTagsPlugin v0.6 (r3117). cbalan's patch works fine, though, and I can confirm that it fixes this bug for the mentioned combination.

comment:10 Changed 7 years ago by Michael Renzmann

Resolution: fixed
Status: reopenedclosed

(In [7372]) Fix a bug that, when trying to create a new wiki page with one or more tags, discarded the wiki page content. Thanks to cbalan for the patch. Fixes #3206.

comment:11 in reply to:  10 Changed 7 years ago by Michael Renzmann

Replying to otaku42:

(In [7372]) Fix a bug that, when trying to create a new wiki page with one or more tags, discarded the wiki page content. Thanks to cbalan for the patch. Fixes #3206.

Guess I had a bad day:

I accidentally committed stuff to the tagged release v0.6 rather than to trunk, which of course was wrong. I'll thus roll back r7372. No need to re-apply the patch to trunk, however, as the issue has been fixed there before.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.