Registering user gives OSError

[Russ Brown]

I recently upgraded both trac and the AccountManager plugin and now registering a new user fails with the following:

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 299, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 189, in dispatch
    resp = chosen_handler.process_request(req)
  File "build/bdist.linux-i686/egg/acct_mgr/web_ui.py", line 117, in process_request
  File "build/bdist.linux-i686/egg/acct_mgr/web_ui.py", line 138, in _do_create
  File "build/bdist.linux-i686/egg/acct_mgr/api.py", line 88, in set_password
  File "build/bdist.linux-i686/egg/acct_mgr/htfile.py", line 50, in set_password
  File "build/bdist.linux-i686/egg/acct_mgr/htfile.py", line 77, in _update_file
  File "/usr/lib/python2.4/fileinput.py", line 231, in next
    line = self.readline()
  File "/usr/lib/python2.4/fileinput.py", line 300, in readline
    os.rename(self._filename, self._backupfilename)
OSError: [Errno 16] Device or resource busy

I think it was the update to trac itself that triggered the problem as I tried updating the plugin to fix the problem, to no avail.

The password file is writeable by trac, as is the directory it is contained within.

[Alec Thomas]

This is a Unicode problem. Following patch fixes it.

trunk/acct_mgr/htfile.py

@@ -74 +74 @@
         filename = self._get_filename()
         written = False
         if os.path.exists(filename):
-            for line in fileinput.input(filename, inplace=True):
+            for line in fileinput.input(str(filename), inplace=True):
                 if line.startswith(prefix):
                     if not written and userline:
                         print userline

0.9/acct_mgr/htfile.py

@@ -74 +74 @@
         filename = self._get_filename()
         written = False
         if os.path.exists(filename):
-            for line in fileinput.input(filename, inplace=True):
+            for line in fileinput.input(str(filename), inplace=True):
                 if line.startswith(prefix):
                     if not written and userline:
                         print userline

[Russ Brown]

Confirmed. Thanks for the speedy fix. :)

[Matt Good]

Well, you shouldn't close the ticket until the fix has been committed.

[Matt Good]

(In [705]) apparently fileinput has a bug handling unicode filenames, so convert it to a string (fixes #323)

[Russ Brown]

My apologies, I'll remember for next time.