Modify

Opened 9 years ago

Closed 5 years ago

#3338 closed task (duplicate)

[Patch] Changes for trac 0.11

Reported by: Prentice Wongvibulsin Owned by: Petr Škoda
Priority: normal Component: TracDownloaderPlugin
Severity: critical Keywords:
Cc: Trac Release: 0.11

Description

revision 3973 is incompatible with trac 0.11. self.env.href should be changed to req.href

prentice@dev:~/TracDownloader-svn/0.11/tracdownloader$ svn diff web_ui.py
Index: web_ui.py
===================================================================
--- web_ui.py	(revision 3973)
+++ web_ui.py	(working copy)
@@ -49,8 +49,7 @@
     def get_navigation_items(self, req):
         """Downloader isinstance visible if user hasattr got permission """
         if req.perm.has_permission('DOWNLOADER_DOWNLOAD'):
-            yield 'mainnav', 'downloader', Markup('<a href="%s">Downloader</a>',
-                                             self.env.href.downloader())
+            yield 'mainnav', 'downloader', Markup('<a href="%s">Downloader</a>') % req.href.downloader()
 
     # IRequestHandler methods

see http://trac.edgewall.org/wiki/TracDev/ApiChanges/0.10

Attachments (0)

Change History (2)

comment:1 Changed 6 years ago by Ryan J Ollos

Summary: changes for trac 0.11[Patch] Changes for trac 0.11

comment:2 Changed 5 years ago by Ryan J Ollos

Resolution: duplicate
Status: newclosed

Fixed on the 0.11 branch in #5540.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Petr Škoda.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.