Modify

Opened 16 years ago

Last modified 4 years ago

#3382 new defect

[PATCH] Multiple fixes

Reported by: James Yonan Owned by:
Priority: normal Component: MediaWikiPluginMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description (last modified by Ryan J Ollos)

This patch is against r2483:

  • Fixed issue where _specialUrlPat regex in replaceFreeExternalLinks was failing to render external links in paragraphs containing newlines because the re.DOTALL regex flag was not being used to allow .* to match newlines.
  • Fixed bug in replaceFreeExternalLinks where the loop variable i was being stepped on for another purpose by code inside the loop.
  • Fixed regex issue where control-char ranges for ascii were being specified to match against unicode strings.
  • Fixed issue where nextItem was called with only one rather than the required two parameters.
  • Support rendering of anchor links such as: [[#heading 4|heading four]]

Attachments (2)

mediawikipluginmacro.diff (5.2 KB) - added by James Yonan 16 years ago.
mediawikipluginmacro_parser_ticket3382_plus.patch (5.1 KB) - added by anonymous 4 years ago.
Re-create patch on this ticket, plus remove duplicate macro instance.

Download all attachments as: .zip

Change History (6)

Changed 16 years ago by James Yonan

Attachment: mediawikipluginmacro.diff added

comment:1 Changed 15 years ago by dclark@…

Thanks - without this patch, this plugin doesn't work in trac 0.11; with it, it does.

If you install system-wide you'll also need this in your trac.ini [components] section:

mediawiki.* = enabled

Debian package with this patch (built on Ubuntu Hardy): http://config.fsf.org/packages/pool/ubuntu-hardy/custom/tracmediawikimacro_1.0-2_all.deb

Changed 4 years ago by anonymous

Re-create patch on this ticket, plus remove duplicate macro instance.

comment:2 Changed 4 years ago by Ryan J Ollos

Owner: permon deleted

comment:3 Changed 4 years ago by Ryan J Ollos

Description: modified (diff)

comment:4 Changed 4 years ago by Ryan J Ollos

In 17832:

TracMediaWikiMacro 1.1dev: Fix multiple issues

  • Fixed issue where _specialUrlPat regex in replaceFreeExternalLinks was failing to render external links in paragraphs containing newlines because the re.DOTALL regex flag was not being used to allow .* to match newlines.
  • Fixed bug in replaceFreeExternalLinks where the loop variable i was being stepped on for another purpose by code inside the loop.
  • Fixed regex issue where control-char ranges for ascii were being specified to match against unicode strings.
  • Fixed issue where nextItem was called with only one rather than the required two parameters.
  • Support rendering of anchor links such as: [[#heading 4|heading four]]

Patch by James Yonan.

Untested by committer.

Refs #3382.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.