Opened 8 years ago

Closed 8 years ago

# Use comma as decimal seperator

Reported by: Owned by: pirsig@… bobbysmith007 normal TimingAndEstimationPlugin normal 0.10

### Description

Hi,

if I use a "," as decimal seperator which is the standard decimal seperator in germany i get this error:

hours changed from NaNh to NaNh.


Is it possible to implement local specific seperators for float values?

Thx,

Alex

### comment:1 Changed 8 years ago by bobbysmith007

um... I am just using python's builtin float() function which converts strings to floats.

I can probably preprocess the string though. I will try to get to this soon.

Russ

### comment:2 Changed 8 years ago by bobbysmith007

Unfortunatly all of the numbers are still going to print with '.' characters (at least right now). Thats alot of work to fix that one right now.

### comment:3 Changed 8 years ago by bobbysmith007

(In [4157]) re #3579 T&E 0.6.8 made the ticket_daemon handle numbers with , as the decimal separator

### comment:4 Changed 8 years ago by bobbysmith007

(In [4158]) re #3579 T&E 0.6.8 made the ticket_daemon handle numbers with , as the decimal separator

### comment:5 Changed 8 years ago by pirsig@…

thx for the quick response and the fix!! I've upgraded to 0.6.8 and it works if i put values in "Add Hours to Ticket"-field but if i do the same with "Estimated Number of Hours"-field. I get: "Estimated Number of Hours: NaNh"

Thx,

Alex

### comment:6 Changed 8 years ago by bobbysmith007

doh... Sorry I didnt even think of that because I dont ever interact with the estimated hours field from python.

I will try to have a similar patch up for you soon that handles estimated hours.

### comment:7 Changed 8 years ago by bobbysmith007

(In [4164]) re #3579 this should hopefully successfully convert all incoming hour strings into a form where decimals are separated by . rather than ,

### comment:8 Changed 8 years ago by bobbysmith007

• Resolution set to fixed
• Status changed from new to closed

(In [4165]) closes #3579 updated version to 0.6.9

### comment:9 Changed 8 years ago by bobbysmith007

damn you are using trac 10. I will upload a new trac 10 version after lunch

### comment:10 Changed 8 years ago by bobbysmith007

(In [4166]) re #3579

I found that this was creating extra changelog crap that it shouldnt have. This fixes that by not inserting changes that were not changes.

### comment:11 Changed 8 years ago by bobbysmith007

(In [4168]) re #3579

Updating this to better support entry of floats that use comma as the decimal separator

version 0.6.9

### comment:12 Changed 8 years ago by bobbysmith007

(In [4170]) closes #3588 re #3579 thanks for catching that, this patch fixes a bug where i would occasionaly try to replace on a value I wasnt sure was a string

### comment:13 Changed 8 years ago by bobbysmith007

(In [4171]) closes #3588 re #3579 thanks for catching that, this patch fixes a bug where i would occasionaly try to replace on a value I wasnt sure was a string