Modify

Opened 9 years ago

Closed 22 months ago

#3738 closed task (fixed)

RSS icons missing

Reported by: Rainer Sokoll Owned by: Odd Simon Simonsen
Priority: normal Component: FullBlogPlugin
Severity: minor Keywords: RSS icons WebUI
Cc: Trac Release: 0.11

Description

In the sidebar, there is a RSS icon only for the archive, but it is missing for "Browse by author:" and "Browse by category:".

The links are there. Could you add the icons to the links?

Attachments (2)

fullblogplugin.diff (3.4 KB) - added by scott@… 8 years ago.
Suggested patch for handling no/one/multiple rss icons in the fullblogplugin sidebar
fullblogplugin.2.diff (2.9 KB) - added by scott@… 8 years ago.
Updated suggested patch for handling no/one/multiple rss icons in the fullblogplugin sidebar

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by Odd Simon Simonsen

I could, and did in fact have them there at some stage in earlier development. The reason I removed them was clutter - it drew way to much unneeded attention having a column of 40 RSS icons. I decided to keep it for the main feed to make that easy to notice, and tone down the other more specific feeds by just using a small text string.

I'm quite happy with current situation, but I'll listen to arguments as to why a large number of feed icons improves the user experience...

comment:2 Changed 9 years ago by Rainer Sokoll

Maybe you could make a config option "show_icon_instead_of_textlink"?

I would like it to have it consistent: Either all links with icon or none.

comment:3 Changed 8 years ago by scott@…

One: Sorry for the duplicate ticket a few days ago.

Two: I'm going to attach a suggested patch. It adds two options:

  1. display_rss_icon (defaults to true, only displays icon in archive)
  2. display_many_rss_icons (defaults to false, displays icons everywhere else)

I hope you find it useful.

Changed 8 years ago by scott@…

Attachment: fullblogplugin.diff added

Suggested patch for handling no/one/multiple rss icons in the fullblogplugin sidebar

Changed 8 years ago by scott@…

Attachment: fullblogplugin.2.diff added

Updated suggested patch for handling no/one/multiple rss icons in the fullblogplugin sidebar

comment:4 Changed 8 years ago by scott@…

Oops ... my first suggested patch included an unrelated patch. Bad me. Corrected in the updated fullblogplugin.2.diff attachment.

comment:5 Changed 22 months ago by Odd Simon Simonsen

Resolution: fixed
Status: newclosed

In 14769:

FullBlogPlugin: Add option to put RSS icons next to all feed links. Closes #3738.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Odd Simon Simonsen.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.