Opened 8 years ago

Closed 8 years ago

#3780 closed enhancement (fixed)

RFE: Add First/Last page links in Matrix view

Reported by: izzy Owned by: Radek Bartoň
Priority: normal Component: ScreenshotsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10


When you are just on it, something small here: Right now, Matrix View just offers previous/next page links. With many screenshots in the collection, it's not that easy to get to the last page to find out the number of the screenshot just added. A link like "first"/"last" page would be very helpful. Optionally you also could add something like "goto page x" ;)

Thank you in advance!

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by Radek Bartoň

Status: newassigned

Implementation for 0.11 branch in r4355.

comment:2 in reply to:  1 Changed 8 years ago by anonymous

Replying to Blackhex:

Implementation for 0.11 branch in r4355.

I just tested this version and it gives me the error:

Traceback (most recent call last):
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11.1-py2.5.egg/trac/web/", line 423, in _dispatch_request
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11.1-py2.5.egg/trac/web/", line 197, in dispatch
    resp = chosen_handler.process_request(req)
  File "build/bdist.freebsd-7.0-RELEASE-p2-i386/egg/tracscreenshots/", line 138, in process_request
    template, content_type = self._do_actions(context, actions)
  File "build/bdist.freebsd-7.0-RELEASE-p2-i386/egg/tracscreenshots/", line 594, in _do_actions
  File "build/bdist.freebsd-7.0-RELEASE-p2-i386/egg/tracscreenshots/", line 70, in render_screenshots
    data['matrix'] = self._build_matrix(index, data['screenshots'])
  File "build/bdist.freebsd-7.0-RELEASE-p2-i386/egg/tracscreenshots/", line 96, in _build_matrix
    row.append(screenshots[index + I])
IndexError: list index out of range

I suspect there is a case that isn't being handled when there are no screenshots to show.

comment:3 Changed 8 years ago by Radek Bartoň

Empty screenshots works fine for me. This would be probably caused by negative index. I've added additional check in r4359.

comment:4 Changed 8 years ago by Radek Bartoň

Resolution: fixed
Status: assignedclosed

This will stay only in 0.11 branch.

Modify Ticket

as closed The owner will remain Radek Bartoň.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.