Modify

Opened 9 years ago

Closed 7 years ago

#3921 closed enhancement (fixed)

[Patch] Configuration options for default values and YUI base URL

Reported by: simon@… Owned by: Prentice Wongvibulsin
Priority: normal Component: TracTicketStatsPlugin
Severity: normal Keywords:
Cc: simon@… Trac Release: 0.11

Description

To get TracTicketStatsPlugin working on our intranet I needed to change the URLs to various YUI scripts to a local YUI setup. I'd like this to be configurable.

I have attached a patch attached that adds a configuration option, yui_base_url, as well as options for the default interval and days to show on the graph, under a ticketstats section.

Attachments (1)

ticketstats-r7633.patch.tgz (1.7 KB) - added by anonymous 8 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 9 years ago by simon@…

Attachment got rejected as spam because of too many external URLs. Find the patch at: http://bleah.co.uk/~simon/stuff/ticketstats-conf.diff

comment:2 Changed 9 years ago by anonymous

Added a '/' after yui_base_url in the template, so both http://yui.yahooapis.com/2.5.2/ and http://yui.yahooapis.com/2.5.2 work.

comment:3 Changed 8 years ago by Prentice Wongvibulsin

Resolution: fixed
Status: newclosed

Applied patch in [6379].

Thanks!

comment:4 Changed 8 years ago by anonymous

Resolution: fixed
Status: closedreopened

The trunk seems to haven't applied the patch. I attach the patch file for the review 7633. Thanks!

Changed 8 years ago by anonymous

Attachment: ticketstats-r7633.patch.tgz added

comment:5 Changed 7 years ago by Ryan J Ollos

Summary: Configuration options for default values and YUI base URL[Patch] Configuration options for default values and YUI base URL

comment:6 Changed 7 years ago by Ryan J Ollos

It appears that the code on the trunk defines the option yui_base_url, but then does not use it.

comment:7 Changed 7 years ago by Ryan J Ollos

The syntax used in this patch is clearsilver templating syntax. The replacement <?cs var:yui_base_url ?> -> ${yui_base_url} should be made.

comment:8 Changed 7 years ago by Ryan J Ollos

This feature was implemented for the TracMetrixPlugin in #5322.

comment:9 Changed 7 years ago by Ryan J Ollos

This will be added in the next commit. Can someone let me know what is the typical location that the Yahoo APIs would be placed in a local installation?

comment:10 Changed 7 years ago by Ryan J Ollos

(In [8638]) Added option to allow YUI base URL to be specified in trac.ini. Refs #3921.

comment:11 Changed 7 years ago by Ryan J Ollos

Resolution: fixed
Status: reopenedclosed

(In [8642]) Re-implementing changes from [8414] on new 0.12 branch. Fixes #3921.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Prentice Wongvibulsin.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.