Modify

Opened 9 years ago

Closed 7 years ago

#3928 closed defect (wontfix)

Number of displayed changelog entries is limit + 1

Reported by: martinbk@… Owned by: Ryan J Ollos
Priority: high Component: ChangeLogMacro
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

As you can see limit=3 but 4 changelogs are shown

Changelog view

ChangeLog macro failed
No node changelogplugin at revision 16558

Attachments (0)

Change History (10)

comment:1 Changed 8 years ago by Ryan J Ollos

Summary: wrong limit parameterNumber of displayed revisions is limit + 1

comment:2 Changed 8 years ago by Ryan J Ollos

Summary: Number of displayed revisions is limit + 1Number of displayed changelog entries is limit + 1

comment:3 Changed 7 years ago by Ryan J Ollos

This bug seems to prevent display of a single revision.

This displays all revisions:

[[ChangeLog(/changelogplugin, 0, 2980)]]

This results in a macro error:

[[ChangeLog(/changelogplugin, , 2980)]]

This results in the display of 2 revision because of #3928.

[[ChangeLog(/changelogplugin, 1, 2980)]]

comment:4 Changed 7 years ago by Ryan J Ollos

Priority: normalhigh

Increasing priority because of comment:3. Some functionality is broken.

comment:5 Changed 7 years ago by Ryan J Ollos

TODO fix ChangeLogPlugin#Examples after fixing this ticket.

comment:6 Changed 7 years ago by Ryan J Ollos

Owner: changed from Alec Thomas to Ryan J Ollos

Changing ticket owner since I have adopted the plugin.

comment:7 Changed 7 years ago by Ryan J Ollos

Component: ChangeLogPluginChangeLogMacro

comment:8 Changed 7 years ago by Ryan J Ollos

Resolution: worksforme
Status: newclosed

This issue seems to be fixed as of [7472] in Trac 0.11.7stable-r9029 and Trac 0.12dev. The ChangeLogMacro on t.h.o. may need to be updated, or else the issue only exists in 0.10.

comment:9 Changed 7 years ago by Ryan J Ollos

Resolution: worksforme
Status: closedreopened

It seems the issue does exist on my Trac 0.11.4 installation, so I'm going to test in a 0.11.4 development environment and see if the issue only appears in earlier Trac versions.

comment:10 Changed 7 years ago by Ryan J Ollos

Resolution: wontfix
Status: reopenedclosed

The issue was resolved after upgrading from Trac 0.11.4 to 0.11.7, so the underlying issue seems most likely to be with the Trac API.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.