#3952 closed defect (fixed)
wiki notification not sent if default_email_format: text/html
Reported by: | Aaron Camac | Owned by: | Robert Corsaro |
---|---|---|---|
Priority: | highest | Component: | AnnouncerPlugin |
Severity: | critical | Keywords: | |
Cc: | sromanow@… | Trac Release: | 0.11 |
Description
This situation produces
2008-10-20 09:35:17,641 Trac[api] ERROR: AnnouncementSystem failed. Traceback (most recent call last): File "build/bdist.linux-i686/egg/announcerplugin/api.py", line 377, in _real_send File "build/bdist.linux-i686/egg/announcerplugin/distributors/email_distributor.py", line 195, in distribute KeyError: u'text/html'
Maybe you were planning on handling this with
def get_format_alternative(self, transport, realm, style):
Or maybe the plan is to just implement a html template in the near future... I think that's what I might do to get around this for now.
Attachments (1)
Change History (12)
comment:1 Changed 16 years ago by
Cc: | sromanow@… added; anonymous removed |
---|
Changed 16 years ago by
Attachment: | distributor.diff added |
---|
comment:2 Changed 16 years ago by
Must have something odd in the format of my diff. Click on the Original Format at the bottom of the attachment to see the file.
comment:3 Changed 16 years ago by
Owner: | changed from Stephen Hansen to Robert Corsaro |
---|---|
Priority: | normal → highest |
Severity: | normal → critical |
comment:4 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
It doesn't make sense to set the default format to a template that doesn't exist. IMHO, it should result in an error. If you create an html template, please contribute it.
comment:5 Changed 16 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
So you are saying that formatters should support all possible formats. Ok, I won't argue with that.
However, I state the that problem stands... you cannot specify default_email_format = text/html in current plugin and have wiki notifications work without the user overriding the default.
It's just that the posted implementation is just not the desired one.
comment:6 Changed 16 years ago by
Ah, I see. You can't specify default format separately for tickets and wiki. So if you want html for tickets, you lose wiki.
comment:8 Changed 16 years ago by
and also the text template encodes urls strangely with <url:http:/sometihng.com>
comment:9 Changed 16 years ago by
while http://something.com would be noticed by most browsers, and mail clients as clickable url.
comment:10 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
This is that change I made... probably would have been less work if I had just created a simple html template for the wiki. Anyway this change does allow for the graceful degradation of the format.