Modify ↓
#4164 closed defect (fixed)
wiki pages without tags have no tag styles
| Reported by: | Shane Caraveo | Owned by: | Alec Thomas |
|---|---|---|---|
| Priority: | normal | Component: | TagsPlugin |
| Severity: | normal | Keywords: | |
| Cc: | Trac Release: | 0.10 |
Description
I can use the tag macro's, but unless the page itself has been tagged, the stylesheet with the tags styles is not loaded. Patch to follow.
Attachments (1)
Change History (4)
Changed 15 years ago by
| Attachment: | tractags-stylesheet.diff added |
|---|
comment:1 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 Changed 14 years ago by
Guess I had a bad day:
I accidentally committed stuff to the tagged release v0.6 rather than to trunk, which of course was wrong. I'll thus roll back r7375 and re-apply the patch to trunk.
comment:3 Changed 14 years ago by
(In [7379]) Ensure that tractags.css gets loaded even on wiki pages that are not tagged. This is required since such pages may call one of the tags macros.
Thanks to mixedpuppy for the patch. I've applied a slightly adjusted version that keeps the call to add_stylesheet inside the _wiki_view method, rather than moving it to the filter_stream method.
Fixes #4164.
Note: See
TracTickets for help on using
tickets.
Doh! Gave the wrong ticket number in the commit message... anyway:
(In [7375]) Ensure that tractags.css gets loaded even on wiki pages that are not tagged. This is required since such pages may call one of the tags macros.
Thanks to mixedpuppy for the patch. I've applied a slightly adjusted version that keeps the call to add_stylesheet inside the _wiki_view method, rather than moving it to the filter_stream method.