Modify

Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#4164 closed defect (fixed)

wiki pages without tags have no tag styles

Reported by: Shane Caraveo Owned by: Alec Thomas
Priority: normal Component: TagsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

I can use the tag macro's, but unless the page itself has been tagged, the stylesheet with the tags styles is not loaded. Patch to follow.

Attachments (1)

tractags-stylesheet.diff (836 bytes) - added by Shane Caraveo 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Shane Caraveo

Attachment: tractags-stylesheet.diff added

comment:1 Changed 7 years ago by Michael Renzmann

Resolution: fixed
Status: newclosed

Doh! Gave the wrong ticket number in the commit message... anyway:

(In [7375]) Ensure that tractags.css gets loaded even on wiki pages that are not tagged. This is required since such pages may call one of the tags macros.

Thanks to mixedpuppy for the patch. I've applied a slightly adjusted version that keeps the call to add_stylesheet inside the _wiki_view method, rather than moving it to the filter_stream method.

comment:2 Changed 7 years ago by Michael Renzmann

Guess I had a bad day:

I accidentally committed stuff to the tagged release v0.6 rather than to trunk, which of course was wrong. I'll thus roll back r7375 and re-apply the patch to trunk.

comment:3 Changed 7 years ago by Michael Renzmann

(In [7379]) Ensure that tractags.css gets loaded even on wiki pages that are not tagged. This is required since such pages may call one of the tags macros.

Thanks to mixedpuppy for the patch. I've applied a slightly adjusted version that keeps the call to add_stylesheet inside the _wiki_view method, rather than moving it to the filter_stream method.

Fixes #4164.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.