Modify

Opened 9 years ago

Closed 7 years ago

#4167 closed defect (fixed)

[patch] Concurrent edits of tickets can overwrite changes to blocking / blocked_by fields

Reported by: Dag Viggo Lokøen Owned by: Noah Kantrowitz
Priority: normal Component: MasterTicketsPlugin
Severity: major Keywords: concurrency, dataloss
Cc: dale.miller@…, Mitar, Luke Cyca Trac Release: 0.11

Description (last modified by Noah Kantrowitz)

Steps to reproduce:

Given two ticket #1 and #2, open both in their own browser window. Go to ticket #2, set blocking to 1 and save. Go to ticket #1, add a comment and click save. You will get the "blocked_by deleted" message.

Analysis: The plugin does not update the changetime of tickets when it modifies them causing MVCC to fail to detect the change.

Solution: Always update the changetime on ticket changes.

Attached patch implements this behaviour.

Attachments (1)

concurrent_fix.patch (785 bytes) - added by Dag Viggo Lokøen 9 years ago.
Patch to fix concurrent edits issue

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Dag Viggo Lokøen

Attachment: concurrent_fix.patch added

Patch to fix concurrent edits issue

comment:1 Changed 9 years ago by anonymous

Cc: dale.miller@… added; anonymous removed

Added address to cc field.

comment:2 Changed 8 years ago by anonymous

Cc: Mitar added

comment:3 Changed 7 years ago by Luke Cyca

This patch works great. I've been using it heavily in production for >6 months.

comment:4 Changed 7 years ago by Luke Cyca

Cc: Luke Cyca added

comment:5 Changed 7 years ago by Noah Kantrowitz

Description: modified (diff)
Resolution: fixed
Status: newclosed

Fix committed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Noah Kantrowitz.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.