Modify

Opened 8 years ago

Closed 9 months ago

#4266 closed defect (wontfix)

setting base_url corrupts ticket URLs in client projects - use tracforge.uri_root instead?

Reported by: jholg Owned by:
Priority: normal Component: TracForgePlugin
Severity: normal Keywords: tracforge notification ticket-URL
Cc: Trac Release: 0.11

Description

TracForgePlugin utilizes trac.base_url option to construct the login/logout links. This breaks email notification ticket URLs for client projects

I suggest using tracforge's own uri_root option instead; this seems to work for my setup, I'm however a bit unsure of what uri_root is supposed to mean in the first place. The doc string says 'The smallest common URI for the whole TracForge setup'.

In a multi-project setup with master project "master" and client projects "client1" and "client2", would that be /master (must be relative)?

Anyhow, for my usecase this configuration does seem to work fine - appropriate patch attached.

Btw TracForgePlugin is great - it's what makes Trac usable in my environment in the first place.

Cheers, Holger

Attachments (1)

auth.py.diff (1.7 KB) - added by jholg 8 years ago.
patch tracforge/linker/auth.py to use tracforge.uri_root instead of master trac.base_url

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by jholg

Attachment: auth.py.diff added

patch tracforge/linker/auth.py to use tracforge.uri_root instead of master trac.base_url

comment:1 Changed 2 years ago by Ryan J Ollos

Owner: Noah Kantrowitz deleted

comment:2 Changed 9 months ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

Plugin is deprecated.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.