Opened 16 years ago
Closed 15 years ago
#4290 closed defect (wontfix)
Make CSS selectable
Reported by: | izzy | Owned by: | Catalin BALAN |
---|---|---|---|
Priority: | normal | Component: | MenusPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.11 |
Description
I think it would be a good idea to make the CSS to use selectable, so one has not to nullify existing settings before applying own ones. I just created a patch for this: it adds a new option to the [menu-custom]
section of the trac.ini
- menu_style
. Here one can either select from the "shipped" CSS files (with my patch: 'simple' (the current one), 'superfish' (the one used previously), and 'trac' - the one I made), or define a complete URL for an own CSS file (which then is taken literally).
[menu-custom] menu_style = superfish
For this to work, the current superfish.css
file has to be split to basic.css
(holding the "essential" part) and simple.css
(holding the "Demo Style"). Plus from the previous superfish.css
, the "Demo Style" part should be added as superfish.css
. If you lost my trac.css
, I'll attach it again here (wait - I'll either attach it again later, there are some modifications I need to finish).
Hope you like and apply the patch ;)
All the best, Izzy.
Attachments (2)
Change History (5)
Changed 16 years ago by
Attachment: | web_ui.py.css.patch added |
---|
Changed 16 years ago by
trac.css
to make the menu looking more like the trac original
comment:1 Changed 16 years ago by
Status: | new → assigned |
---|
Hey Izzy,
This is great, but personally I believe that any special customizations should be done using wiki:TracInterfaceCustomization#SiteAppearance "method".
The default css shipped with this plugin should only match trac default's theme. This is the reason why [menu-custom]serve_ui_files exists, to prevent the default css to be added, if there is a custom theme in place.
I do like this idea(your patch is great) but having in mind :
- the wiki:TracInterfaceCustomization
- for a custom theme, one css file can "cover everything", including menus and other plugins (plus is easy to maintain it)
- having files served from /static (custom theme case) would work better than /chrome/...
I consider this approach out of scope.
Thank you, Catalin Balan
comment:2 Changed 16 years ago by
(In [5021]) MenusPlugin: - More trac-alike look thanks to Izzy. refs #4290 #4264 #4274
comment:3 Changed 15 years ago by
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
Adding stylesheet selection to
trac.ini