Modify

Opened 8 years ago

Closed 7 years ago

#4466 closed defect (worksforme)

[Patch] FullBlogNotificationPlugin broken with 0.12dev

Reported by: jouvin@… Owned by: Ryan J Ollos
Priority: normal Component: FullBlogNotificationPlugin
Severity: major Keywords:
Cc: Trac Release: 0.12

Description

Hi,

I tried to use FullBlogNotifier with current Trac trunk (0.12dev-7795) but it fails because it relies on a compatibility function for Python 2.3, itemgetter, that was marked for removal in 0.11 and removed in 0.12...

The easy fix is to import itemgetter directly with from operator import itemgetter.

Michel

Attachments (0)

Change History (5)

comment:1 Changed 7 years ago by Ryan J Ollos

Summary: FullBlogNotifier broken with 0.12dev[Patch] FullBlogNotificationPlugin broken with 0.12dev

comment:2 Changed 7 years ago by Ryan J Ollos

Owner: changed from Nick Loeve to Ryan J Ollos

Reassigning ticket since I am now maintainer of the plugin.

comment:3 Changed 7 years ago by Ryan J Ollos

I don't see where itemgetter is used. Could you point me to the file/location?

comment:4 in reply to:  3 ; Changed 7 years ago by Michel Jouvin <jouvin@…>

Replying to rjollos:

I don't see where itemgetter is used. Could you point me to the file/location?

In fact this is a very old report and I cannot remember the exact problem. I'd say that if was probably a Python 2.3 issue adn we now moved our Trac server to Python 2.4. The plugin is not using itemgetter perse but the get method called probably need it and it is not here before Python 2.4 if I remember.

I think you can close the ticket. Thanks for the follow-up...

Cheers,

Michel

comment:5 in reply to:  4 Changed 7 years ago by anonymous

Resolution: worksforme
Status: newclosed

Replying to Michel Jouvin <jouvin@lal.in2p3.fr>:

In fact this is a very old report and I cannot remember the exact problem. I'd say that if was probably a Python 2.3 issue adn we now moved our Trac server to Python 2.4. The plugin is not using itemgetter perse but the get method called probably need it and it is not here before Python 2.4 if I remember.

I think you can close the ticket. Thanks for the follow-up...

Okay, thanks. It seems to work with the current 0.12dev trunk and Python 2.6.

Modify Ticket

Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.