Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#4695 closed defect (fixed)

Patch to correct anchor pages redirects

Reported by: Andrey.Regentov@… Owned by: Martin Scharrer
Priority: normal Component: ServerSideRedirectPlugin
Severity: normal Keywords: anchor, redirect
Cc: Trac Release: 0.11

Description

ServerSideRedirectPlugin does not redirect well to pages with anchor links, e.g.

   [[redirect(MyPage#MyAnchor)]]

I even filed a bug to trac (http://trac.edgewall.org/ticket/8072) but it appears that #MyAnchor should be the last part in resulting URL.

I.e. by now it looks as http://mytrac.domain/wiki/MyPage#MyAnchor?redirectedfrom=OtherPage instead of http://mytrac.domain/wiki/MyPage?redirectedfrom=OtherPage#MyAnchor

Enclosed patch fixes this issue.

Attachments (1)

patch_from_0.11-r5285 (988 bytes) - added by Andrey.Regentov@… 9 years ago.
patch to fix Anchor redirects

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Andrey.Regentov@…

Attachment: patch_from_0.11-r5285 added

patch to fix Anchor redirects

comment:1 Changed 9 years ago by Martin Scharrer

Resolution: fixed
Status: newclosed

Thanks for the patch, I applied it now.

Please use the unified format (e.g. diff -Nur or svn diff) and a file extention of '.patch' or '.diff' for future patches to improve the display in Trac and for simpler application using patch.

@All:
Should any problems regarding this patch occur please reopen this ticket.

comment:2 Changed 9 years ago by Andrey.Regentov@…

Please use the unified format (e.g. diff -Nur or svn diff) and a file extention of '.patch' or '.diff' for future patches to improve the display in Trac and for simpler application using patch.

Thanks for advice. That was my first patch. I will post unified diffs since now.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Martin Scharrer.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.