Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#4722 closed defect (fixed)

post_process_request not preserve content_type, which cause text/plain templates fail to render.

Reported by: Jiang Xin Owned by: Jiang Xin
Priority: highest Component: TracCoSignPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.11


post_process_request in traccosign/ carelessly set content_type to None. It's bad if template is not a html template but a text template.

This bug cause plain text output of source code revision log raise a exception:

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/trac/web/", line 459, in _dispatch_request
  File "/usr/lib/python2.5/site-packages/trac/web/", line 237, in dispatch
  File "/usr/lib/python2.5/site-packages/trac/web/", line 740, in render_template
    template = self.load_template(filename, method=method)
  File "/usr/lib/python2.5/site-packages/trac/web/", line 724, in load_template
    return self.templates.load(filename, cls=cls)
  File "/var/lib/python-support/python2.5/genshi/template/", line 227, in load
    filename, encoding=encoding)
  File "/var/lib/python-support/python2.5/genshi/template/", line 265, in _instantiate
  File "/var/lib/python-support/python2.5/genshi/template/", line 67, in __init__
  File "/var/lib/python-support/python2.5/genshi/template/", line 406, in __init__
    raise TemplateSyntaxError(e.msg, self.filepath, e.lineno, e.offset)
TemplateSyntaxError: not well-formed (invalid token): line 1, column 1 (/usr/lib/python2.5/site-packages/trac/versioncontrol/templates/revisionlog.txt, line 1)

Attachments (0)

Change History (2)

comment:1 Changed 9 years ago by Jiang Xin

Resolution: fixed
Status: newclosed

(In [5325]) Fixed #4722: wrong content_type return value from post_process_request.

comment:2 Changed 9 years ago by Jiang Xin

(In [5326]) Upgrade to 0.1.2-1.5325. See #4722.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jiang Xin.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.