Modify

Opened 8 years ago

Closed 8 years ago

#4739 closed defect (worksforme)

MasterTicketsPlugin conflicts with other plugins

Reported by: fgutierrez@… Owned by: Noah Kantrowitz
Priority: normal Component: MasterTicketsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

In the file web_ui.py line 43 the plugin checks for "ticket" in the path, then it assumes that there is going to be a key "ticket" in the data dictionary. Other plugins like the CustomFieldAdmin use URL like /admin/ticket/customfields so then an exception is generated.

If the if condition is changed to:

    def post_process_request(self, req, template, data, content_type):
        if req.path_info.startswith('/ticket/') and 'ticket' in data:
            tkt = data['ticket']
            links = TicketLinks(self.env, tkt)

the other plugins can include "ticket" in their url.

Attachments (0)

Change History (1)

comment:1 Changed 8 years ago by Noah Kantrowitz

Resolution: worksforme
Status: newclosed

The condition is .startswith('/ticket/'). /admin/ticket doesn't start with /ticket/ so it won't trigger the filter.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Noah Kantrowitz.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.