Remove 'login' link from /login page

[J Evan S]

I don't know why but for some reason we keep getting users that click the login link again after entering their credentials instead of the login button or just pressing enter. Of course all it does is reset the screen.

[ejucovy]

I think this is a good idea, but it's out of scope for the PermRedirectPlugin. This plugin's only responsibility is catching permission errors and redirecting to the login screen; the implementation of the login screen itself is handled by Trac core and/or AccountManagerPlugin for most environments.

It would be pretty straightforward to implement a filter to remove the "login" link in a separate plugin; it might also be worth filing an upstream request for this change. Either way, closing as "invalid" since PermRedirectPlugin really has no business messing with the contents of the login page.