Modify

Opened 8 years ago

Closed 8 years ago

#4861 closed defect (fixed)

t&e breaks core unit test

Reported by: Shane Caraveo Owned by: Russ Tyndall
Priority: normal Component: TimingAndEstimationPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Running trac unit tests with t&e installed breaks one unit test. The issue is the monkey patching of ReportModule._send_csv

====================================================================== ERROR: test_csv_escape (trac.ticket.tests.report.ReportTestCase)


Traceback (most recent call last):

File "/Users/shanec/svn/workspace/trunk/build/vendor/trac/trac/ticket/tests/report.py", line 55, in test_csv_escape

self.report_module._send_csv(req, cols, rows)

File "/Users/shanec/svn/workspace/trunk/build/plugins/timingandestimationplugin/timingandestimationplugin/reports_filter.py", line 116, in _send_csv

id = report_id_from_filename(filename)

File "/Users/shanec/svn/workspace/trunk/build/plugins/timingandestimationplugin/timingandestimationplugin/reports_filter.py", line 103, in report_id_from_filename

m = billing_report_fname_regex.match(text)

TypeError: expected string or buffer


Attachments (0)

Change History (1)

comment:1 Changed 8 years ago by Russ Tyndall

Resolution: fixed
Status: newclosed

(In [5494]) closes #4861 patched that so that it passes the unit tests. Thanks for the bug report.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Russ Tyndall.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.