Infinite recursion when using r5468 to get all search filters

[Jason Winnebeck]

get_search_filters causes "RuntimeError: maximum recursion depth exceeded" whenever trying to load the search page (not performing a query).

The stack trace loops forever on the line 81 (shown below).

                available_filters += source.get_search_filters(req)

Reverting back to r5455, the plugin works for me.

[Álvaro Iradier]

I think I guess what the problem is... I have Search All enabled in only one of my projects. I guess you have search all enabled in more than one project... is that right?

[Jason Winnebeck]

Yes I have 7 Trac projects, and each of them have this plugin installed. I thought that was the only way to set this up? I guess the other way is to have a master project? I haven't figured out any of those plugins, mostly because I haven't gotten a good feeling that they are stable/complete yet.

[Álvaro Iradier]

It's a bug in my plugin, anyways, but I didn't notice it as I have a kind of master or index project with SearchAll, and no Search All in the others.

I'll fix it as soon as I get back to work on monday, it should be an easy fix.

Thanks for the reprt.

[Álvaro Iradier]

(In [5515]) Fixes infinite recursion if searchall plugin enabled in more than one project. Closes #4908