Jump to edited section after edit

[kontakt@…]

When I edit a section of a large Article, it would be nice to see the browser jump to that section's heading after I hit the Save button. If for any reason this behavior was not wanted, it could maybe be toggled by a checkbox near that button.

I'm using SectionEditPlugin 0.1 on Trac 0.11.4, Ubuntu Hardy 8.4.2 Server, Opera 9.64 Browser.

[Ryan J Ollos]

Let me prefix this by saying I absolutely don't know what I'm doing here, but I hacked around with this enough to get the following patch working.

The changes are:

1. In the Javascript function, I append the name of the heading's anchor to the url fragment.
2. In filter_stream, I followed the pattern of inserting a hidden html element, by adding the anchor name as a hidden element.
3. In pre_process_request, I get the anchor name and use that to construct a redirect, as is done for Trac tickets after a comment is posted. See ​web_ui.py in Trac 0.12 for reference.

I'm particularly unsure of step (2) Maybe there is a better way? Any help and suggestions would be greatly appreciated!!

Patch against [11180].

0.12/tracsectionedit/htdocs/js/tracsectionedit.js

@@ -5 +5 @@
         var href_edit = document.location.href;
         href_edit = (href_edit.indexOf('?')==-1?'?':href_edit+'&')+"action=edit&section=";
         return this.filter("*[@id]").each(function(){
-            $("<a class='anchor'>[<span>edit</span>]</a>").attr("href", href_edit + cnt++).attr("title", title).appendTo(this);
+            var anchor = $(this).attr('id')
+            $("<a class='anchor'>[<span>edit</span>]</a>").attr("href", href_edit + cnt++ + "&anchor=" + anchor).attr("title", title).appendTo(this);
         });
     }
     

0.12/tracsectionedit/web_ui.py

@@ -49 +49 @@
                 req.args['text'] = "%s%s%s"%(req.args.get('section_pre'), 
                                              section_text, 
                                              req.args.get('section_post'))
+                fragment = '#' + req.args.get('anchor')
+                req.redirect(req.href.wiki(req.args['page']) + fragment)
         return handler
 
     def post_process_request(self, req, template, data, content_type):
@@ -70 +72 @@
             section_element = html.input(type='hidden', name='section', id='section', value=req.args.get('section'))
             pre_element = html.input(type='hidden', name='section_pre', id='section_pre', value=''.join(section_pre))
             post_element = html.input(type='hidden', name='section_post', id='section_post', value=''.join(section_post))
+            anchor_element = html.input(type='hidden', name='anchor', id='anchor', value=''.join(req.args.get('anchor')))
             
-            section_html = html(section_element, pre_element, post_element)
+            section_html = html(section_element, pre_element, post_element,anchor_element)
             stream = stream | Transformer('//textarea[@name="text"]').empty().append(section_text).before(section_html)
             stream = stream | Transformer('//div[@id="content"]//h1').append("/%s (section %s)"%(section_text[:section_text.find('\n')].strip(" = \r\n"), req.args['section']))
             if not self.preview_whole_page:

[Ryan J Ollos]

(In [11192]) Refs #4970: Created a dev branch for version 0.3, which includes the patch from comment:2.

The 0.11 and 0.12 branches will be merged to produce a single code line for this plugin at the time version 0.3 is released.

[Ryan J Ollos]

Well, this patch is no good because it does a redirect in pre_process_request and therefore the change doesn't get saved. It seems like the redirect needs to be done in post_process_request, however, I can't find a way to retrieve req.args['anchor'] in post_process_request, and I don't see a way to pass the value from pre_process_request to post_process_request. I spent about 5 hours on this, so I'm pretty much stuck at this point. It's possible the plugin needs some major redesign in order to implement this feature.

[Ryan J Ollos]

(In [11204]) Refs #4970: Removing 0.12dev branch for now.

[Ryan J Ollos]

I'm stuck on this after about 8 hours of effort and experimentation. Maybe someone will come along and help me out? ;) Otherwise, I'm moving on for now ...

[ms1014]

I found worked solution.

[Ryan J Ollos]

Great, thank you. I will take a look.

[phaebz]

Is there an update on this? Can I somehow help in testing?

[Ryan J Ollos]

Refocusing.