Modify

Opened 8 years ago

Closed 6 years ago

#4980 closed defect (worksforme)

[PATCH] tags css messes with custom query page css

Reported by: anonymous Owned by: Odd Simon Simonsen
Priority: normal Component: TagsPlugin
Severity: normal Keywords: CSS
Cc: Trac Release: 0.11

Description

tractags overrides #query in css, making it float right. This affects the query form on the custom query page. When tractags is installed, if you collapse the "columns" box on the custom query page, the form shifts to the right.

The attached patch fixes tractags to only include it's css files on pages that use tractags.

Attachments (1)

tractags-customqueryfix.patch (1.1 KB) - added by Shane Caraveo 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Shane Caraveo

comment:1 Changed 8 years ago by Odd Simon Simonsen

Owner: changed from Alec Thomas to Odd Simon Simonsen

Are you using latest tags plugin from trunk?

I open custom query, and Firebug does not report the tags stylesheet as loaded. The line numbers in the patch does not correspond to lines found in latest trunk either.

Could you please try with latest tags trunk?

comment:2 Changed 6 years ago by Steffen Hoffmann

Keywords: CSS added
Resolution: worksforme
Status: newclosed

Can't verify this either. This doesn't apply to trunk.

Please reopen with a verifiable claim, if needed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Odd Simon Simonsen.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.