Modify

Opened 11 years ago

Closed 11 years ago

#519 closed defect (fixed)

if 'reply_all' is set, and there is no cc, email2trac fails

Reported by: ncarlson@… Owned by: anonymous
Priority: normal Component: EmailtoTracScript
Severity: major Keywords:
Cc: ncarlson@… Trac Release: 0.9

Description

If I have 'reply_all' enabled, and there is no 'cc' field on an incoming e-mail, email2trac bombs with the following in syslog:

Jul 18 09:42:12 rt email2trac: Traceback (most recent call last): Jul 18 09:42:12 rt email2trac: File "/usr/bin/email2trac", line 818, in ? tktparser.parse(sys.stdin) Jul 18 09:42:12 rt email2trac: File "/usr/bin/email2trac", line 487, in parse self.new_ticket(m) Jul 18 09:42:12 rt email2trac: File "/usr/bin/email2trac", line 413, in new_ticket self.set_reply_fields(tkt, msg) Jul 18 09:42:12 rt email2trac: File "/usr/bin/email2trac", line 315, in set_reply_fields

ticketcc? = self.to_unicode(mail_list)

Jul 18 09:42:12 rt email2trac: UnboundLocalError: local variable 'mail_list' referenced before assignment

Looks like there's no check to make sure that the cc field isn't blank?

This is on a Debian box with Postfix and trac 0.9.

Attachments (1)

email2trac.diff (932 bytes) - added by ncarlson@… 11 years ago.
Patch to fix reply_all with no cc's.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by ncarlson@…

Attachment: email2trac.diff added

Patch to fix reply_all with no cc's.

comment:1 Changed 11 years ago by anonymous

Cc: ncarlson@… added; anonymous removed
Owner: changed from Bas van der Vlies to anonymous
Status: newassigned

Thanks for the patch i will apply it to the trunk version

comment:2 Changed 11 years ago by anonymous

Applied patch to trunk version

comment:3 Changed 11 years ago by Bas van der Vlies

Resolution: fixed
Status: assignedclosed

new version released

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain anonymous.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.