Modify

Opened 8 years ago

Last modified 6 years ago

#5243 new defect

Ticketmodifiedfiles does not work with intertrac links

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Component: TicketModifiedFilesPlugin
Severity: normal Keywords: patch
Cc: Trac Release: 0.11

Description

The plugin does not recognise an intertrac environment, so it will report a lot of collisions between tickets in multiple Tracs.

I took the liberty to make the following change, my Python knowledge is limited so I don't guarantee anything.

ticketmodifiedfiles.py line 112:

        project = self.env.config['project']
        proj_name = project.get('name', 'name')
        cursor.execute("SELECT rev, time, author, message FROM revision WHERE message LIKE '%%" + proj_name + ":#%s%%'" % id)

Now only tickets in the same (current) Trac will be taken into account.

Perhaps you can review this and add it to the trunk version.

kind regards,

Hans de Rijck.

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by Emilien Klein

Status: newassigned

OK, I acknowledge this ticket. However I'm not going to add this to the code, as I'm currently not able to do tests. I'll have a look at it as soon as I'm able to test again. Thanks for the patch! Groeten.

comment:2 Changed 8 years ago by anonymous

Hi,

Thanks for your response. I don't know if it is a lot of work, but when you are at this, would it be possible to change the installation procedure so that I can simply put the .py file in the Trac plugins directory? Those Python eggs make me nervous ;)

groeten terug

Hans

comment:3 Changed 6 years ago by Emilien Klein

Keywords: patch added

comment:4 Changed 6 years ago by Emilien Klein

Owner: changed from Emilien Klein to Ryan J Ollos
Status: assignednew

Reassigning as part of maintainership transfer of TicketModifiedFiles to rjollos.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Ryan J Ollos.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.