[patch] Stack trace escapes to user when htdigest file is not writeable

[reallifesim@…]

The set_password api function can throw a TracError that web_ui._create_user fails to check for.

This will happen if the HtDigest file used for authentication is not writable by the apache user.

Attached patch with a fix.

[reallifesim@…]

patch for web_ui.py

[anonymous]

Hmm, that patch seems to be empty/unreadable. Here it is inline:

70c70,74 < mgr.set_password(user, password) ---

try:

mgr.set_password(user, password)

except TracError, e:

e.acctmgr = acctmgr raise e

It's against web_ui.py

[Steffen Hoffmann]

Actually there is just an issue with parsing certain diff files by the internal viewer. However I doubt that this will be an problem, as soon as #4276 get's fixed. And this will be really soon. The extra code shouldn't be needed then.

[Steffen Hoffmann]

Could you please check trunk code, if this issue persists after [9272]?

We should get a proper error already at the time of opening the file for writing (in htfile.py, lin1 149), so this should be obsolete by now. Correct?

[Steffen Hoffmann]

(In [9347]) AccountManagerPlugin: Improve error handling when writing to password files, closes #4040 and #5247, refs #6803.

Some messages without i18n markup were found while examining the code, so corresponding additions and updates to message catalogs are included as well.