#5273 closed defect (fixed)
SyntaxErrors (for python <2.5) in PyGit.py and git_fs.py in revision 5846
Reported by: | anonymous | Owned by: | Herbert Valerio Riedel |
---|---|---|---|
Priority: | normal | Component: | GitPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.11 |
Description
Syntax Errors:
source:/gitplugin/0.11/tracext/git/git_fs.py#5846#L361
source:/gitplugin/0.11/tracext/git/PyGIT.py#5846#L361
# python -V Python 2.4.3 # svn update At revision 5846. # python tracext/git/git_fs.py File "tracext/git/git_fs.py", line 361 yield (self.path, rev, Changeset.EDIT if not is_last else Changeset.ADD) ^ SyntaxError: invalid syntax # python tracext/git/PyGIT.py File "tracext/git/PyGIT.py", line 89 with self.__lock: ^ SyntaxError: invalid syntax
Attachments (2)
Change History (11)
comment:1 Changed 15 years ago by
Changed 15 years ago by
Attachment: | trac-gitplugin-fix-python-2.4.patch added |
---|
Patch for Python 2.4. Applies cleanly against r6157
Changed 15 years ago by
Attachment: | trac-gitplugin-fix-python-2.4.2.patch added |
---|
Patch for Python 2.4. Applies cleanly against r6157
comment:5 follow-up: 8 Changed 15 years ago by
Owner: | changed from Herbert Valerio Riedel to roadrunner |
---|---|
Status: | new → assigned |
Replying to anonymous:
The patches are empty.
No they aren't - it's just trac's display of the attachment that's broken. Click on the "Original Format" link at the bottom of the page to download the patch and you'll see that they are complete.
comment:6 Changed 15 years ago by
Owner: | changed from roadrunner to Herbert Valerio Riedel |
---|---|
Status: | assigned → new |
(oops, didn't mean to change the owner)
comment:7 Changed 15 years ago by
Summary: | SyntaxErrors in PyGit.py and git_fs.py in revision 5846 → SyntaxErrors (for python <2.5) in PyGit.py and git_fs.py in revision 5846 |
---|
comment:8 Changed 15 years ago by
Replying to roadrunner:
Replying to anonymous:
The patches are empty.
No they aren't - it's just trac's display of the attachment that's broken. Click on the "Original Format" link at the bottom of the page to download the patch and you'll see that they are complete.
actually the problem is, that the patch contains binary data, because .pyc
files were diffed:
diff -Naurp tmp/gitplugin/0.11/tracext/__init__.pyc gitplugin/0.11/tracext/__init__.pyc --- tmp/gitplugin/0.11/tracext/__init__.pyc 1970-01-01 10:00:00.000000000 +1000 +++ gitplugin/0.11/tracext/__init__.pyc 2009-07-06 15:15:16.000000000 +1000
comment:9 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
It looks like python 2.5 is required for the more recent 0.11 versions