Opened 12 years ago

Closed 11 years ago

Incorrect author in timeline and log - GitPlugin shows committer instead of author

Reported by: Owned by: egagnon@… Herbert Valerio Riedel normal GitPlugin normal stuge 0.12

Description

When the author differs from the committer, GitPlugin seems to favor the committer over the author as "Trac Author". This has impact in the timeline, log, and various other locations.

GitPlugin seems to have this concept of "Trac Author" in addition to "git-author" and "git-committer", as can be seen on: http://sablecc.org/changeset/1a3b6173986aa9cfc694acba0ecbbb7e40028f22

There might be reasons why a project would like to show the committer name, instead of the author name, in the timeline and log to show committer activity. Yet, other projects might have very few, or even a single committer in their official repository, as encouraged by Git. In such a case, it might make more sense to show the real author name in the timeline and log.

I suggest using a configuration flag to chose which of the git-author or git-committer to use as "Trac Author", so that everybody is pleased.

comment:1 Changed 12 years ago by roadrunner

I'm attaching two patches that provide a configuration option for this. The first patch just sets up a couple things (and is identical to the first patch for #2685); the second is the main change, and provides a trac_author config option which defaults to 'committer' (i.e. the original behaviour).

Changed 12 years ago by roadrunner

A small preparatory change

Changed 12 years ago by roadrunner

Add trac_author config option

comment:2 follow-up:  3 Changed 12 years ago by anonymous

Thanks!

How should I go about testing this? I currently use "apt-get trac-git" on Debian.

How should I go about testing this? I currently use "apt-get trac-git" on Debian.

I don't know what that exactly installs (just the egg, or the expanded egg?). But you can check out the plugin from subversion or grab the zipped source for the plugin (see the links on the GitPlugin page), and then do something like

cd gitplugin/0.11
patch -p2 < .../pass_repo.patch
patch -p2 < .../trac_author.patch
easy_install .


This may overwrite the installed git-plugin files from you Debian package (and in fact you probably want to remove the Debian package first to avoid conflicts and confusion).

comment:4 Changed 11 years ago by anonymous

Could this please be integrated in the trunk?

comment:5 Changed 11 years ago by stuge

This change does look good. I would also like to see it included in the plugin.

comment:6 Changed 11 years ago by Herbert Valerio Riedel

Resolution: → worksforme new → closed

fyi, a slightly different imeplementation has been implemented in 1e8a1470527d24aa23c99bd10afcfca224115943

comment:7 Changed 11 years ago by anonymous

Trac Release: 0.11 → 0.12

Changed 11 years ago by stuge

Return email address if trac_user_rlookup fails

comment:8 Changed 11 years ago by stuge

Perfect! :) I'd like to suggest also the patch I just attached, to fall back onto only the email address if no rlookup match is found.

Modify Ticket

Change Properties