Modify

Opened 8 years ago

Closed 7 years ago

#5462 closed enhancement (fixed)

Ticket Notification Formatting

Reported by: Gökdeniz Karadağ Owned by: Robert Corsaro
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: J Evan S, Ryan J Ollos Trac Release: 0.11

Description

Hi, thanks for this plugin.

Formatting for ticket notifications can be improved. First, the horizontal rule after "Changes" is not on its own line. I get e-mails like this.

....
Severity: Normal
---------------------------------------------------------------------
Changes (by xxxxx): 

 * Cc from 'yyyyy' to (deleted)
 * Priority from 'High' to 'Low'---------------------------------------------------------------------
Comment:

comment content

I believe to fix this , {% end %} at ticket_email_plaintext.txt, line 25 should be on its own line. But I'm not sure about it. The horizontal rule may even be removed and replaced with a blank line, just like in original trac notifications.

Ticket property list can be like trac's own notifications format_props function may help. I am not sure if plugins can use core trac functions but at least it can be duplicated.

currently Announcer links only to the ticket's URL (.../ticket/230). Original notifications put a link to exact comment (like http://example.com/trac/ticket/230#comment:4 ). That would be useful to go to a specific comment in a ticket with lots of comments.

Attachments (0)

Change History (7)

comment:1 Changed 8 years ago by anonymous

Cc: J Evan S added; anonymous removed

comment:2 Changed 8 years ago by J Evan S

Would also like to see fields listed in two columns like in the default Trac emails.

comment:3 Changed 8 years ago by anonymous

Cc: Ryan J Ollos added
Summary: Ticket Notification FormattingTicket Notification Formatting

comment:4 Changed 8 years ago by Robert Corsaro

Status: newassigned

comment:5 Changed 8 years ago by Robert Corsaro

(In [7176]) Format fixed. addresses #5462

comment:6 Changed 7 years ago by Robert Corsaro

(In [7583]) fixes format.

addresses #5462 merge -r7176

comment:7 Changed 7 years ago by Robert Corsaro

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Robert Corsaro.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.