Modify ↓

Opened 18 years ago

Closed 18 years ago

#559 closed defect (fixed)

Invalid link expansion

Reported by: Emmanuel Blot Owned by: Peter Kropf
Priority: high Component: GraphvizPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.9

Description

The expand_wiki_links() method is far too restrictive.

For example, it prevents from using javascript-based URL, as the regular expression 

re.search('href="(.*?)"', html_url)

silently fails, which least to a Python exception.

Attaching a patch to workaround this bug.

An typical case of failure happens if the URL in the dot graph is defined as follows: 

URL="javascript:window.parent.location.href='http://...'"

Attachments (1)

expandlinks.patch​ (802 bytes) - added by Emmanuel Blot 18 years ago.
Allows Javascript URLs

Download all attachments as: .zip

Change History (4)

Changed 18 years ago by Emmanuel Blot

Attachment: expandlinks.patch​ added

Allows Javascript URLs

comment:1 Changed 18 years ago by Emmanuel Blot

(sorry about not submitting a patch against the very last release of graphviz, trac-hacks is in trouble with https so I can't update my working copy through an http proxy. Nevertheless, the patch has been actually written against the latest zipped copy of graphviz)

comment:2 Changed 18 years ago by Emmanuel Blot

#560 to see why javascript URL is an important feature to support.

comment:3 Changed 18 years ago by Peter Kropf

Resolution: → fixed
Status: new → closed

(In [1134]) Added support for javascript URLs. Fixes #559.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Peter Kropf.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.