Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5595 closed enhancement (fixed)

Improve message displayed when BLOG_VIEW permissions not granted

Reported by: Ryan J Ollos Owned by: Odd Simon Simonsen
Priority: normal Component: FullBlogPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

For the standard Trac components (e.g. tickets, reports, etc ...), when a user attempts to navigate to a page for which they don't have permissions, Trac displays a message such as:

REPORT_VIEW permissions required to view this item

However, when a user navigate to /blog, but doesn't have BLOG_VIEW permissions, the message is:

No handler matched request to /blog

It would be nice if this message read:

BLOG_VIEW permissions required to view this item

Its a very minor thing, which is why I'm posting it as an enhancement. I might try to work on it since I want to learn more about the Trac permissions scheme.

Attachments (0)

Change History (6)

comment:1 Changed 8 years ago by Ryan J Ollos

Summary: Message display when permissions not grantedImprove message displayed when BLOG_VIEW permissions not granted

comment:2 Changed 8 years ago by Odd Simon Simonsen

Resolution: fixed
Status: newclosed

(In [6402]) FullBlogPlugin: Deferring permission check from match_request() to process_request() in order to provide a useful message. Closes #5595.

comment:3 Changed 8 years ago by Ryan J Ollos

Thanks for the fix! This is one of the most well maintained plug-ins on trac-hacks.

comment:4 in reply to:  3 ; Changed 8 years ago by Odd Simon Simonsen

Replying to rjollos:

Thanks for the fix! This is one of the most well maintained plug-ins on trac-hacks.

Appreciate the positive feedback - kudos welome at Ohloh :-)

comment:5 in reply to:  4 Changed 8 years ago by anonymous

Replying to osimons:

Appreciate the positive feedback - kudos welome at Ohloh :-)

Certainly, its the least I could do!

comment:6 Changed 8 years ago by Ryan J Ollos

I updated the FullBlogPlugin on my Trac instance, and I see the following message when accessing the blog for a user that doesn't have this permission.

BLOG_VIEW privileges are required to perform this operation on Blog:

That is perfect. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Odd Simon Simonsen.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.