Modify

Opened 8 years ago

Closed 7 years ago

#5639 closed defect (fixed)

Line endings not displayed correctly during preview

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: TicketChangePlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

I'm assuming that this applies to the EmailProcessorMacro, though it only happens while editing a comment using the TicketChangePlugin, so perhaps that component is at fault. See attached screen captures. The line endings are not displayed correctly during the ticket preview.

Attachments (2)

EmailProcessorMacroComment.png (19.7 KB) - added by Ryan J Ollos 8 years ago.
EmailProcessorMacroCommentPreview.png (109.0 KB) - added by Ryan J Ollos 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Ryan J Ollos

Changed 8 years ago by Ryan J Ollos

comment:1 Changed 8 years ago by Ryan J Ollos

The first image in my description shows the ticket change after it is submitted. The second image shows the ticket change during a preview.

comment:2 Changed 8 years ago by Ryan J Ollos

Component: EmailProcessorMacroTicketChangePlugin
Owner: changed from John Hampton to Sergei Luchko

I noticed that the preview is only showing the changed portion of the ticket, and since I don't see the issue when previewing a new comment, I think the problem most likely lies with the TicketChangePlugin. So, I'm moving this ticket over to that component.

comment:3 in reply to:  2 Changed 8 years ago by Ryan J Ollos

Replying to rjollos:

I noticed that the preview is only showing the changed portion of the ticket

Never mind, this is not true.

comment:4 Changed 7 years ago by Ryan J Ollos

#5683 closed as a duplicate.

comment:5 Changed 7 years ago by Ryan J Ollos

Owner: changed from Sergei Luchko to Ryan J Ollos
Status: newassigned

Plugin is using wiki_to_html, which is a pre-0.11 compatibility method. It looks like it has been superseded by format_to_html, but I don't know how to obtain the appropriate arguments for the new method (in particular, context), so I'll just fix the existing call to wiki_to_html for now.

comment:6 Changed 7 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

(In [9654]) Newline were not displayed correctly during preview. Fixes #5639.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.