Opened 10 years ago

Closed 10 years ago

# Announcer should have a page listing all Watched items

Reported by: Owned by: anonymous Robert Corsaro high AnnouncerPlugin normal 0.11

### Description

If this functionality can't be duplicated/merged, please change the wording of "Watch This"/"Unwatch This" to something that doesn't closely match the wording used in the WatchlistPlugin. Perhaps "Add to Announcements" or "Remove from Announcements" or something similar.

See #4744 for this workaround.

### comment:1 follow-up:  3 Changed 10 years ago by Ryan J Ollos

It would be nice put an entry in the metanav ('Watchlist') that links to the page with the table of all watched pages for a particular user.

I second this

### comment:3 in reply to:  1 ; follow-up:  7 Changed 10 years ago by Martin Scharrer

It would be nice put an entry in the metanav ('Watchlist') that links to the page with the table of all watched pages for a particular user.

This is exactly what the WatchlistPlugin does.

### comment:4 Changed 10 years ago by Martin Scharrer

Priority: normal → high

The WatchlistPlugin rev.[6834] now actively supports the AnnouncerPlugin (see #4744) and allows to switch notification of wikis and tickets watched by the WatchlistPlugin on or off. This is not exactly the same as requested by this ticket but it comes close. Please note that wikis/tickets can be independently watched by both plugins.

I agree with the ticket creator that the navbar entries "Watch This"/"Unwatch This" would be changed to someting else not including 'watch', because this is to close to the WatchlistPlugin (uses "Watch"/"Unwatch"). Maybe having it configurable by the trac.ini config, so it can be changed by people which want to use both plugins?

### comment:5 Changed 10 years ago by Robert Corsaro

I would accept that patch

### Changed 10 years ago by Martin Scharrer

Patch to make context navigation entries ('Watch this','Unwatch this') configurable

### comment:6 Changed 10 years ago by Martin Scharrer

Owner: changed from Robert Corsaro to Martin Scharrer new → assigned

The attached patch allows the user (Trac admin) to rename or disable the context navigation entries.

## Examples

Rename the cxtnav entries:

[announcer]
ctxtnav_names = Notify me, Do not notify me


Disable the entries:

[announcer]
ctxtnav_names =


### comment:7 in reply to:  3 Changed 10 years ago by Ryan J Ollos

This is exactly what the WatchlistPlugin does.

If these are two plugin are working nicely together now, that will be great! I will try installing the WatchListPlugin shortly. I have been using the AnnouncerPlugin for 6 months.

### comment:9 Changed 10 years ago by Robert Corsaro

Resolution: → fixed assigned → closed

(In [6916]) Allow the ctxnav names for "watch/unwatch this" to be relabeled or shut off (by setting to blank). This patch was contributed by martin_s closes #5682

### comment:10 Changed 10 years ago by anonymous

Thanks for the patch, I really appreciate it.

### comment:11 follow-up:  12 Changed 10 years ago by Ryan J Ollos

I'm working on upgrading to install this patch and I added this change to the wiki page to document the configuration parameter. Please correct if this could be documented better.

Thanks!

### comment:12 in reply to:  11 Changed 10 years ago by Martin Scharrer

this change to the wiki >page to document the configuration parameter. Please correct if this could be documented >better.

### comment:14 Changed 10 years ago by Martin Scharrer

Resolution: fixed closed → reopened

Sorry, I got the indexes wrong therefore the ctxtnav item names are swapped at the moment.

Either change the order of the names in the documentation or fix the indexes in the source code. I would prefer the latter because it is more natural to specify the 'Watch' action name before the 'Unwatch' one.

Simply replaces index [0] with [1] and vice versa:

• ## subscribers/watchers.py

 realm, resource = resource.split('/', 1) if self.is_watching(req.session.sid, not req.authname == 'anonymous', realm, resource): action_name = self.ctxtnav_names[1] else: action_name = self.ctxtnav_names[0] else: action_name = self.ctxtnav_names[1] add_ctxtnav(req, tag.a( action_name, href=req.href.watch(realm, resource)

### Changed 10 years ago by Martin Scharrer

Patch to fix wrong index order and rename notifications.

### comment:15 Changed 10 years ago by Martin Scharrer

In my opinion the messages "You are now watching this resource for changes." and "You are no longer watching this resource for changes." should also be changed, so that the user is not confusing this with the addition and removal from the watchlist.

I made this changes in the attachment:announcer_ctxtnav_config2.patch .

### comment:16 Changed 10 years ago by Martin Scharrer

Owner: changed from Martin Scharrer to Robert Corsaro reopened → new

### comment:17 Changed 10 years ago by Robert Corsaro

Resolution: → fixed new → closed

(In [7138]) reverse ctxtnames and check for exist fixes #5682

### Modify Ticket

Change Properties