Modify

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5858 closed defect (fixed)

Code inserted is not XHTML valid

Reported by: Mitar Owned by: Dave
Priority: normal Component: TimelineUserFilterPlugin
Severity: normal Keywords:
Cc: Mitar Trac Release: 0.11

Description

Code inserted is not XHTML valid. Around <label> should be a <div>. Fix is simple, just add tag.div(...) around result in _user_field_input:

   def _user_field_input(self, req):
        return tag.div(tag.label("Filter users: ",
                         tag.input(type="text",
                                   name="users",
                                   value=req.args.get('users', ''),
                                   style_="width:60%")))

Attachments (0)

Change History (2)

comment:1 Changed 7 years ago by asic_druide

Resolution: fixed
Status: newclosed

Attached version fixes #5400, #5421 and #5858.

comment:2 Changed 7 years ago by Dave

(In [7595]) Patch from asic_druide to fix #5400, #5421 and #5858. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Dave.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.