Modify ↓
Opened 15 years ago
Last modified 10 years ago
#5958 new enhancement
GeoTicketPlugin should cache unlocatable results
Reported by: | Jeff Hammel | Owned by: | |
---|---|---|---|
Priority: | high | Component: | GeoTicketPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.11 |
Description
locate_ticket
is currently quite slow on the /query
screen if there are tickets with unlocatable locations. This is because these locations are not cached:
def locate_ticket(self, ticket): if ticket.id: results = get_all_dict(self.env, "select latitude, longitude from ticket_location where ticket='%s'" % ticket.id) if results: return ticket['location'], (results[0]['latitude'], results[0]['longitude']) if ticket['location'] is None or not ticket['location'].strip(): raise GeolocationException # XXX blindly assume UTF-8 try: location = ticket['location'].encode('utf-8') except UnicodeEncodeError: raise location, (lat, lon) = self.geolocate(location) if ticket.id: self.set_location(ticket.id, lat, lon) return location, (lat, lon)
A set of unlocatable locations should be hashed on the instance so that additional requests need not be made for bad locations (or more precisely, they need not be made more than once per instance).
Attachments (0)
Change History (3)
comment:1 Changed 15 years ago by
Status: | new → assigned |
---|
comment:2 Changed 15 years ago by
Status: | assigned → new |
---|
comment:3 Changed 10 years ago by
Owner: | Jeff Hammel deleted |
---|
Note: See
TracTickets for help on using
tickets.