Modify

Opened 7 years ago

Closed 5 years ago

#6007 closed defect (wontfix)

[Patch] Configuration parameters `from_email` and `from_name` are ignored

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: FullBlogNotificationPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

In the [fullblog-notification] section of trac.ini, if from_name contains whitespace, only the portion preceding the whitespace appears in the email subject line.

For example with the following configuration,

from_name = My Trac Blog
subject_template = $prefix $blog.title $action

The subject line appears as,

[My] Test Post post_updated;

See also #6006 for other requested formatting improvements in the subject line.

Attachments (1)

notification.patch (2.3 KB) - added by Ryan J Ollos 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Ryan J Ollos

Summary: If `from_name` contains whitespace, only the portion preceding the whitespace appears in the email subject lineIf `from_name` parameter contains whitespace, only the text preceding the whitespace appears in the email subject line

comment:2 Changed 7 years ago by Ryan J Ollos

There seems to be another problem here. The FullBlogNotificationEmail.notify method calls NotifyEmail.notify, which sets from_email and from_name using the config options from the notification section. Therefore, the settings from the [fullblog-notification] are overwritten.

comment:3 Changed 7 years ago by Ryan J Ollos

Summary: If `from_name` parameter contains whitespace, only the text preceding the whitespace appears in the email subject line[Patch] Configuration parameters `from_email` and `from_name` are ignored

I'm no longer seeing the original issue. What I am seeing is what is noted in comment:2, so I will provide a patch for that. The patch probably needs a bit more work, but seems to be working at the moment.

Changed 7 years ago by Ryan J Ollos

Attachment: notification.patch added

comment:4 Changed 7 years ago by Ryan J Ollos

Owner: changed from Nick Loeve to Ryan J Ollos

Reassigning ticket since I am now maintainer of the plugin.

comment:5 Changed 7 years ago by Ryan J Ollos

This is probably the last bug to be fixed with the FullBlogNotificationPlugin, and then the focus will be on enhancing the FullBlogAnnouncementsPlugin.

Though if there are any straightforward fixes/enhancements, or patches submitted, then I will update this plugin.

comment:6 Changed 7 years ago by Ryan J Ollos

It appears that we can probably just remove the following configuration directives from the [fullblog-notification] section, as they are redundant with what is implemented in the [notification] section.

from_email = trac+blog@localhost
from_name = None
smtp_always_cc = []

comment:7 Changed 5 years ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

Plugin is deprecated.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.