Opened 11 years ago

Closed 5 years ago

#615 closed defect (wontfix)

javascript failed in Internet Explorer

Reported by: shuoshuo+trac@… Owned by: Noah Kantrowitz
Priority: normal Component: CtxtnavAddPlugin
Severity: critical Keywords:
Cc: Trac Release: 0.10


  1. Background
  1. Fix
    • ctxtnavadd.js
                          if(li_node.getAttribute('class') == 'last'
                              || li_node.getAttribute('className') == 'last') {

Attachments (1)

ctxtnavadd.js (1.1 KB) - added by Kenneth Xu 10 years ago.
fixed IE problem.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by Dave Gynn

I can verify this fix solves the problem in IE. You also need to make a similar change to the code that resets the 'last' item's class.

+    new_li.setAttribute('className','last');
+    old_li.removeAttribute('className');

comment:2 Changed 10 years ago by jason_field

I think there is a neater way to do it,

In find_old_last() instead of the getAttribute call;

if( li_node.className == 'last' ) {

and in add_ctxtnav() instead of the setAttribute call;

new_li.className = 'last'; old_li.className = ;

These changes seem to work on both IE and Firefox for me, and don't require doing essentially the same thing twice :)

comment:3 Changed 10 years ago by Noah Kantrowitz

I've totally rework the JavaScript in the 0.11 version using jQuery. I don't really intend to backport these changes (as I am currently very lacking of free time), but if someone wants to make a backport patch, I'll take a look.

Changed 10 years ago by Kenneth Xu

Attachment: ctxtnavadd.js added

fixed IE problem.

comment:4 Changed 10 years ago by Kenneth Xu

I fixed this IE problem before I come to this ticket. file attached attachment:ctxtnavadd.js

Can somebody help to check into 0.10 branch?

comment:5 Changed 5 years ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

Plugin is deprecated.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Noah Kantrowitz.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.