Modify

Opened 7 years ago

Closed 7 years ago

#6257 closed defect (fixed)

Incompatible with 0.11.6 rc 1

Reported by: anonymous Owned by: Stephen Hansen
Priority: normal Component: BlackMagicTicketTweaksPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.11

Description

It appears this plugin is incompatible with 0.11.6 rc1

When going to create a ticket with this plugin enabled (regardless of what settings are set for the plugin) the following error is thrown

2009-11-25 12:25:33,587 Trac[main] ERROR: Internal Server Error: 
Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/Trac-0.11.6rc1-py2.6.egg/trac/web/main.py", line 450, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.6/dist-packages/Trac-0.11.6rc1-py2.6.egg/trac/web/main.py", line 227, in dispatch
    data, content_type)
  File "/usr/local/lib/python2.6/dist-packages/Trac-0.11.6rc1-py2.6.egg/trac/web/chrome.py", line 739, in render_template
    stream |= self._filter_stream(req, method, filename, stream, data)
  File "build/bdist.linux-x86_64/egg/genshi/core.py", line 128, in __or__
    return Stream(_ensure(function(self)), serializer=self.serializer)
  File "/usr/local/lib/python2.6/dist-packages/Trac-0.11.6rc1-py2.6.egg/trac/web/chrome.py", line 842, in inner
    data)
  File "build/bdist.linux-x86_64/egg/blackmagic/blackmagic.py", line 55, in filter_stream
    if disabled or istrue(self.config.get('blackmagic', '%s.disable' % field, False)):
  File "build/bdist.linux-x86_64/egg/blackmagic/blackmagic.py", line 13, in istrue
    if v.lower() in ('yes', 'true', '1', 'on'):
AttributeError: 'bool' object has no attribute 'lower'

Attachments (0)

Change History (2)

comment:1 Changed 7 years ago by anonymous

I've found a fix.

On line 13 change if v.lower() in ('yes', 'true', '1', 'on'): to if str(v).lower() in ('yes', 'true', '1', 'on'):

comment:2 Changed 7 years ago by obs

Resolution: fixed
Status: newclosed

(In [7197]) Ensured when checking if value is true compared value is a string, fixes #6257

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Stephen Hansen.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.