Opened 15 years ago
Last modified 4 years ago
#6295 new defect
Bitten Build Notifications don't work
Reported by: | Kaveh | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | AnnouncerPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.11 |
Description
When you move [notification] to [announcer] in trac.ini, it breaks the build notifications sent by Bitten. Is there any way we could honor those like they are in the original trac notification schema?
Attachments (2)
Change History (19)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
This has been discussed previously with regard to the FullBlogPlugin. The author has stated that a plugin will need to be written, as he did for the FullBlogAnnouncementsPlugin.
comment:3 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
http://bitten.edgewall.org/ticket/538
Feel free to backport the patch to the 0.11 version of announcerplugin. It should just be a matter of changing the API method names, and using the old way of setting email headers (not email decorator).
comment:4 Changed 15 years ago by
I got the API method names, that's easy, but I'm not familiar enough with announcerplugin yet to know the old way of setting email headers. Could you point me to an example where it's implemented?
comment:5 Changed 15 years ago by
Actually, I might be able to use the example in comment:2 if that works.
comment:6 Changed 15 years ago by
I've been testing the FullBlogAnnouncementsPlugin, and it works for the most part. There are some issues yet to be worked out, but I've opened tickets for the ones I've discovered so far and you can take a look in the bug reports if you'd like.
comment:7 Changed 15 years ago by
format_headers and format_subject are the old, 0.11 way of doing things. See announcerplugin/formatter/ticket_email.py and wiki_email.py for examples.
I'm moving all these plugins into announcer to simplify things. I'll commit the trunk versions of fullblog, bitten and accountmanager within the next couple of days so you can see how it's setup.
Thanks for backporting. You can ask for commit on trac-hacks mailing list for 0.11dev and I'll reply that you have my permission.
comment:8 Changed 15 years ago by
Awesome....thanks so much for the guidance...I really hope that announcerplugin will replace trac's rudimentary notification system.
On another note, it would be nice if we could maintain a "CC list" for different build configurations, rather than just notify anyone of every build. Have you thought about that at all?
comment:9 Changed 15 years ago by
No, to be honest I've never used bitten. This was an attempt at a straight port from the notify.py file. Osimons might have some insight into build cc lists, or you could try using a trac Filter to add the field, and an AnnouncerSubscriber to use it.
comment:10 Changed 14 years ago by
Does this need to be patched into bitten? or can it be added as a module in AnnouncerPlugin (if I were to submit a working patch)?
Changed 14 years ago by
Attachment: | add_bitten_announcements_for_0.11dev.patch added |
---|
patch for getting bitten to work with 0.11dev
comment:11 follow-up: 12 Changed 14 years ago by
I did it! I finally got some free time and got the bitten patch backported to 0.11dev. If anyone else wants to check it over and give it a shot, that'd be great. It might be worth a quick code review by you doki.
comment:12 Changed 14 years ago by
Replying to kavehv:
I did it! I finally got some free time and got the bitten patch backported to 0.11dev. If anyone else wants to check it over and give it a shot, that'd be great. It might be worth a quick code review by you doki.
I should mention that this is a patch for bitten 0.6b2 to make it work with the 0.11dev branch. I'm not sure yet about moving everything to the announcerplugin egg. Is that trivial to do?
comment:13 Changed 14 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Changed 14 years ago by
Attachment: | add_bitten_support.patch added |
---|
patch to apply to announcerplugin 0.11dev to add support for bitten
comment:14 Changed 14 years ago by
I wrote and uploaded a patch you could apply to the 0.11dev branch. It basically does what ticket component subscriber does but for build configurations in Bitten. You essentially get a list of build configs that you can subscribe to. I hope others find it useful too.
comment:15 Changed 14 years ago by
Doki, I have a couple questions:
- regarding Trac 0.12, bitten won't support this until version 0.7, so doesn't it make sense to work on bitten for the 0.11dev branch?
- if I make a whole bunch of enhancements to the 0.11dev branch (with regards to bitten notifications), how easy will it be to port into the trunk when it comes time to implement them on 0.12?
comment:16 Changed 10 years ago by
4 Years and no news?
Trac 1.0.1, Bitten 0.7dev-r1026 and TracAnnouncer 1.0dev-r12503 do not work together: always says the following:
Trac[announce] INFO: BittenAnnouncedEventProducer invoked for build <Build 11529> Trac[announce] DEBUG: build status: S Trac[announce] INFO: Creating announcement for build <Build 11529> Trac[api] DEBUG: AnnouncementSystem has found the following subscriptions: Trac[api] DEBUG: AnnouncementSystem sent event in 0.0 seconds. Trac[notify] INFO: BittenNotify invoked for build <Build 11529> Trac[notify] DEBUG: build status: S Trac[notify] INFO: Sending notification for build <Build 11529>
Is there a way to get notifications back working?
comment:17 Changed 9 years ago by
Owner: | Robert Corsaro deleted |
---|---|
Status: | reopened → new |
Any word on if this would be easy to fix?