Opened 18 years ago
Closed 3 years ago
#634 closed enhancement (wontfix)
Automatically detect Unicode Perforce servers
Reported by: | Lewis Baker | Owned by: | Lewis Baker |
---|---|---|---|
Priority: | normal | Component: | PerforcePlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.10 |
Description
Further to ticket #632, the need for the [perforce]
configuration section could be completely eliminated if the plugin automatically detected whether the Perforce server was running in Unicode mode or not.
This is possible on Perforce 2004.2 or later servers by setting the P4CHARSET to 'none'
and running the equivalent of p4 -ztag info
and looking for the '... unicode enabled'
line and if present then setting the P4CHARSET to 'utf8'
.
This would add a little overhead (a few ms) to connecting to the Perforce server. But this could be overcome by still allowing the unicode = 1/0
line and only performing the introspection of the server if this line was not present.
Sounds like a no-brainer. Who cares about a few mS overhead? It should query every time, and the config option should be removed. 2004.2 is very old now.