Modify

Opened 7 years ago

Closed 5 years ago

#6427 closed defect (fixed)

[Patch] When configuring a different workflow, autocomplete doesn't work on reassign

Reported by: MartinBeyer Owned by: Ryan J Ollos
Priority: normal Component: AutocompleteUsersPlugin
Severity: minor Keywords: jquery
Cc: Mitar Trac Release: 0.11

Description (last modified by Ryan J Ollos)

because input fields with other names than action_reassign_reassign_owner are created. They seem all to end with reassign_owner, however. (didn't check that in the sources)

workaround:

replace in autocompleteusers\htdocs\js\autocomplete_ticket.js

$("#action_reassign_reassign_owner").autocomplete("../users", {

with:

`$("[id$=reassign_owner]").autocomplete("../users", { `

Attachments (1)

autocomplete_ticket.js.diff (517 bytes) - added by jholg 6 years ago.
Patch diff based on r9775

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by Ryan J Ollos

Owner: changed from Jeff Hammel to Ryan J Ollos

Changing ticket owner to be new maintainer.

comment:2 Changed 6 years ago by Ryan J Ollos

Description: modified (diff)
Keywords: jquery added
Priority: normalhigh

comment:3 Changed 6 years ago by Ryan J Ollos

Summary: When configuring a different workflow, autocomplete doesn't work on reassign[Patch] When configuring a different workflow, autocomplete doesn't work on reassign

comment:4 Changed 6 years ago by jholg

I can confirm this patch works for me (I'm currently running on r9775 of this plugin).

Relevant trac code is in trac/ticket/default_workflow.py (line numbers as of Trac 0.11.4):

    226         if 'set_owner' in operations:
    227             id = 'action_%s_reassign_owner' % action
    228             selected_owner = req.args.get(id, req.authname)

Attaching mercurial diff for this change based on r9775.

Changed 6 years ago by jholg

Attachment: autocomplete_ticket.js.diff added

Patch diff based on r9775

comment:5 Changed 5 years ago by Ryan J Ollos

Status: newassigned

Mitar has this in his branch as well: fc124698af4b. I'm pulling in the changes now.

comment:6 Changed 5 years ago by Ryan J Ollos

Cc: Mitar added; anonymous removed

comment:7 Changed 5 years ago by Ryan J Ollos

(In [11728]) Refs #6427: Enable autocomplete to work on reassign when a custom workflow is enabled.

Setting plugin version back to 0.4.2dev.

  • 0.4.2 will be the release for Trac 0.11.
  • 0.5.0 will be the release for Trac 0.12.

comment:8 Changed 5 years ago by Ryan J Ollos

Ticket will be left open for feedback until 0.4.2/0.5.0 are released.

comment:9 Changed 5 years ago by Mitar

We have been using this (in my branch) for some time now and it works.

comment:10 in reply to:  9 Changed 5 years ago by Ryan J Ollos

Replying to mitar:

We have been using this (in my branch) for some time now and it works.

Which version of Trac are you running?

comment:11 Changed 5 years ago by Mitar

0.12.2 there.

comment:12 Changed 5 years ago by Ryan J Ollos

Priority: highnormal

comment:13 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Fix is in the current dev version of the trunk and will be released with version 0.4.2 of the plugin.

Modify Ticket

Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.